[U-Boot] [PATCH v4 1/9] cmd: add efitool command

[AKASHI Takahiro]

On Tue, Jan 15, 2019 at 04:31:35AM +0100, Heinrich Schuchardt wrote:
> On 1/15/19 3:55 AM, AKASHI Takahiro wrote:
> > Currently, there is no easy way to add or modify UEFI variables.
> > In particular, bootmgr supports BootOrder/BootXXXX variables, it is
> > quite hard to define them as u-boot variables because they are represented
> > in a complicated and encoded format.
> > 
> > The new command, efitool, helps address these issues and give us
> > more friendly interfaces:
> >  * efitool boot add: add BootXXXX variable
> >  * efitool boot rm: remove BootXXXX variable
> >  * efitool boot dump: display all BootXXXX variables
> >  * efitool boot order: set/display a boot order (BootOrder)
> >  * efitool setvar: set an UEFI variable (with limited functionality)
> >  * efitool dumpvar: display all UEFI variables
> > 
> > As the name suggests, this command basically provides a subset fo UEFI
> > shell commands with simplified functionality.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> 
> Hello Takahiro,
> 
> thanks a lot for your patch series. The additional command is really useful.
> 
> Unfortunately the implementation of sub-commands does not follow the
> coding style of other sub-commands. Could you please have a look at the
> current doc/README.commands
> 
> http://git.denx.de/?p=u-boot.git;a=blob;f=doc/README.commands

OK.

> I think it should be easy to convert your code to follow the
> implementation style suggested there and used all over U-Boot.
>
> Sorry that I did not put this into an earlier comment. I only learnt
> about this recently by a review from Simon and then updated the README.
> 
> Please, add the new file in MAINTAINERS to the EFI PAYLOAD section.

Sure

Thanks,
-Takahiro Akashi


> Best regards
> 
> Heinrich