[U-Boot] [U-Boot, v2, 4/7] ARM: mach-omap2: Kconfig: Allow OMAP5 devices to set entry point

[Andrew F. Davis]

On 1/17/19 9:11 AM, Andrew F. Davis wrote:
> On 1/17/19 8:15 AM, Tom Rini wrote:
>> On Thu, Jan 17, 2019 at 08:13:21AM -0600, Andrew F. Davis wrote:
>>> On 1/16/19 3:14 PM, Tom Rini wrote:
>>>> On Wed, Dec 05, 2018 at 11:51:33AM -0600, Andrew F. Davis wrote:
>>>>
>>>>> Like AM33xx and AM43xx, DRA7xx and AM57xx devices may need to
>>>>> have an non-standard boot address in memory. This may be due
>>>>> to the device being a high security variant, which place the
>>>>> Initial SoftWare (ISW) after certificates and secure software.
>>>>>
>>>>> Allow these devices to set this from Kconfig.
>>>>>
>>>>> Signed-off-by: Andrew F. Davis <afd at ti.com>
>>>>> Reviewed-by: Tom Rini <trini at konsulko.com>
>>>>> ---
>>>>>  arch/arm/mach-omap2/Kconfig        | 13 +++++++++++++
>>>>>  arch/arm/mach-omap2/am33xx/Kconfig | 15 ---------------
>>>>>  include/configs/ti_omap5_common.h  |  2 +-
>>>>>  3 files changed, 14 insertions(+), 16 deletions(-)
>>>>
>>>> Turns out this breaks OMAP3 among others as the question is asked there
>>>> now and we have no default value (nor I suspect a reasonable one).
>>>
>>> The only thing changed is ti_omap5_common.h, the default provided in
>>> that file is 0x40301350, would it be okay to just make that the default
>>> for ISW_ENTRY_ADDR for all platforms that included that file?
>>
>> Well, ISW_ENTRY_ADDR doesn't make sense for OMAP3, right?  I suspect the
>> problem is that in moving it from mach-omap2/am33xx/Kconfig to
>> mach-omap2/Kconfig you need to update the depends on guards so that it
>> doesn't show up where it's not used.
>>
> 
> CONFIG_SPL_TEXT_BASE should be converted to Kconfig, but cannot be right
> now due to some other platforms using strange methods for setting it in
> header files. So we have ISW_ENTRY_ADDR in Kconfig that is used to set
> CONFIG_SPL_TEXT_BASE. ISW_ENTRY_ADDR can be defined for any platform, I
> just may not be used depending on what headers it includes and whether
> they use it to set CONFIG_SPL_TEXT_BASE.
> 
> The change here is using it in ti_omap5_common.h, which a lot more
> platforms use is seems than I noticed. So all these platforms now need
> ISW_ENTRY_ADDR set to what the header to set them as (0x40301350).
> 
> Again, all this goes away when CONFIG_SPL_TEXT_BASE gets converted to
> Kconfig.

Scratch that, it's not SPL_TEXT_BASE converted to Kconfig (that's done
for some platforms) it looks to be us overwriting it still in many places.

Anyway posted v3 with fix for above.

Andrew

> 
> Andrew
>