[U-Boot] [PATCH v2 05/11] net: macb: Fix GEM hardware detection

[Anup Patel]

> -----Original Message-----
> From: Alexander Graf [mailto:agraf at suse.de]
> Sent: Friday, January 18, 2019 6:41 PM
> To: Anup Patel <Anup.Patel at wdc.com>; Rick Chen <rick at andestech.com>;
> Bin Meng <bmeng.cn at gmail.com>; Joe Hershberger
> <joe.hershberger at ni.com>; Lukas Auer <lukas.auer at aisec.fraunhofer.de>;
> Masahiro Yamada <yamada.masahiro at socionext.com>; Simon Glass
> <sjg at chromium.org>
> Cc: Palmer Dabbelt <palmer at sifive.com>; Paul Walmsley
> <paul.walmsley at sifive.com>; Atish Patra <Atish.Patra at wdc.com>;
> Christoph Hellwig <hch at infradead.org>; U-Boot Mailing List <u-
> boot at lists.denx.de>
> Subject: Re: [PATCH v2 05/11] net: macb: Fix GEM hardware detection
> 
> 
> 
> On 18.01.19 14:03, Anup Patel wrote:
> >
> >
> >> -----Original Message-----
> >> From: Alexander Graf [mailto:agraf at suse.de]
> >> Sent: Friday, January 18, 2019 5:22 PM
> >> To: Anup Patel <Anup.Patel at wdc.com>; Rick Chen
> <rick at andestech.com>;
> >> Bin Meng <bmeng.cn at gmail.com>; Joe Hershberger
> >> <joe.hershberger at ni.com>; Lukas Auer
> >> <lukas.auer at aisec.fraunhofer.de>; Masahiro Yamada
> >> <yamada.masahiro at socionext.com>; Simon Glass <sjg at chromium.org>
> >> Cc: Palmer Dabbelt <palmer at sifive.com>; Paul Walmsley
> >> <paul.walmsley at sifive.com>; Atish Patra <Atish.Patra at wdc.com>;
> >> Christoph Hellwig <hch at infradead.org>; U-Boot Mailing List <u-
> >> boot at lists.denx.de>
> >> Subject: Re: [PATCH v2 05/11] net: macb: Fix GEM hardware detection
> >>
> >>
> >>
> >> On 18.01.19 12:19, Anup Patel wrote:
> >>> From: Atish Patra <atish.patra at wdc.com>
> >>>
> >>> Fix MID bit field check to correctly identify all GEM hardwares.
> >>>
> >>> The check is updated as per macb driver in Linux location:
> >>> <linux_sources>/drivers/net/ethernet/cadence/macb_main.c:259
> >>>
> >>> Signed-off-by: Atish Patra <atish.patra at wdc.com>
> >>
> >> This is missing your SoB.
> >
> > Sure, I will add my SoB.
> >
> > Since the work was done by Atish independently, I thought my SoB is
> > not required.
> 
> Imagine the SoB as a marker for "this went through my hands". If you send a
> patch from someone else - even though you did modify a single line - it still
> went through your hands and thus your SoB should occur at the end.
> 
> Similarly the first SoB usually means "this was the original author".
> 
> So imagine you started to work on a patch, then Atish improved it and
> eventually you send it out, the SoB chain would look like this:
> 
>   Signed-off-by: Anup Patel <Anup.Patel at wdc.com>
>   Signed-off-by: Atish Patra <atish.patra at wdc.com>
>   Signed-off-by: Anup Patel <Anup.Patel at wdc.com>
> 
> But you don't have to be too nit-picky about that part. The one thing people
> will care about is that the original author is in the SoB list and that your SoB is
> at the end of the list, because you are the one sending the patch set.

Thanks for the info.

I was not aware of this convention around SoB.

Regards,
Anup