[U-Boot] [PATCH 1/1] efi_loader: do not use symbolic links

Heinrich Schuchardt xypron.glpk at gmx.de
Mon Jan 21 18:30:42 UTC 2019


Symbolic links are not supported on all file systems, e.g. not on FAT. So
it is not wise to use them in our source tree.

Use a qualified path to refer to lib/efi_loader/efi_freestanding.c in
scripts/Makefile.lib instead.

Reported-by: Alexander Graf <agraf at suse.de>
Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
Hello Alex,

may be it is better to merge this patch with efi-next commit
78501c873594 ("efi_loader: use freestanding library for efi apps")
to avoid trouble. But this would require that you shuffle the commits on the
efi-next branch.

Best regards

Heinrich
---
 lib/efi_selftest/efi_freestanding.c | 1 -
 scripts/Makefile.lib                | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
 delete mode 120000 lib/efi_selftest/efi_freestanding.c

diff --git a/lib/efi_selftest/efi_freestanding.c b/lib/efi_selftest/efi_freestanding.c
deleted file mode 120000
index 4b7edd52bd..0000000000
--- a/lib/efi_selftest/efi_freestanding.c
+++ /dev/null
@@ -1 +0,0 @@
-../efi_loader/efi_freestanding.c
\ No newline at end of file
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 4facb76ace..9e331ee9d9 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -389,7 +389,7 @@ $(obj)/efi_reloc.o: $(srctree)/arch/$(ARCH)/lib/$(EFI_RELOC:.o=.c) $(recordmcoun
 	$(call cmd,force_checksrc)
 	$(call if_changed_rule,cc_o_c)
 
-$(obj)/%_efi.so: $(obj)/%.o $(obj)/efi_crt0.o $(obj)/efi_reloc.o $(obj)/efi_freestanding.o
+$(obj)/%_efi.so: $(obj)/%.o $(obj)/efi_crt0.o $(obj)/efi_reloc.o $(srctree)/lib/efi_loader/efi_freestanding.o
 	$(call cmd,efi_ld)
 
 # ACPI
-- 
2.20.1



More information about the U-Boot mailing list