[U-Boot] [PATCH 1/6] watchdog: bcm6345: switch to raw I/O functions

Marek Behun marek.behun at nic.cz
Mon Jan 21 23:37:53 UTC 2019


Hi,
You have to add some commit message, even if it is only one line,
describing why are you doing these changes.
Marek

On Mon, 21 Jan 2019 18:07:28 +0100
Philippe Reynes <philippe.reynes at softathome.com> wrote:

> Signed-off-by: Philippe Reynes <philippe.reynes at softathome.com>
> ---
>  drivers/watchdog/bcm6345_wdt.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/bcm6345_wdt.c
> b/drivers/watchdog/bcm6345_wdt.c index e1bd73d..44f5662 100644
> --- a/drivers/watchdog/bcm6345_wdt.c
> +++ b/drivers/watchdog/bcm6345_wdt.c
> @@ -32,8 +32,8 @@ static int bcm6345_wdt_reset(struct udevice *dev)
>  {
>  	struct bcm6345_wdt_priv *priv = dev_get_priv(dev);
>  
> -	writel_be(WDT_CTL_START1_MASK, priv->regs + WDT_CTL_REG);
> -	writel_be(WDT_CTL_START2_MASK, priv->regs + WDT_CTL_REG);
> +	writel(WDT_CTL_START1_MASK, priv->regs + WDT_CTL_REG);
> +	writel(WDT_CTL_START2_MASK, priv->regs + WDT_CTL_REG);
>  
>  	return 0;
>  }
> @@ -50,7 +50,7 @@ static int bcm6345_wdt_start(struct udevice *dev,
> u64 timeout, ulong flags) timeout = WDT_VAL_MAX;
>  	}
>  
> -	writel_be(timeout, priv->regs + WDT_VAL_REG);
> +	writel(timeout, priv->regs + WDT_VAL_REG);
>  
>  	return bcm6345_wdt_reset(dev);
>  }
> @@ -64,8 +64,8 @@ static int bcm6345_wdt_stop(struct udevice *dev)
>  {
>  	struct bcm6345_wdt_priv *priv = dev_get_priv(dev);
>  
> -	writel_be(WDT_CTL_STOP1_MASK, priv->regs + WDT_CTL_REG);
> -	writel_be(WDT_CTL_STOP2_MASK, priv->regs + WDT_CTL_REG);
> +	writel(WDT_CTL_STOP1_MASK, priv->regs + WDT_CTL_REG);
> +	writel(WDT_CTL_STOP2_MASK, priv->regs + WDT_CTL_REG);
>  
>  	return 0;
>  }



More information about the U-Boot mailing list