[U-Boot] [PATCH] pci: Add PCI_SLOT macro to include/pci.h

[Stefan Roese]

Hi Bin,

On 22.01.19 03:11, Bin Meng wrote:
> On Tue, Jan 22, 2019 at 8:32 AM Simon Glass <sjg at chromium.org> wrote:
>>
>> Hi Stefan,
>>
>> On Sat, 19 Jan 2019 at 00:46, Stefan Roese <sr at denx.de> wrote:
>>>
>>> This macro will be used the by the Marvell Armada XP/38x PCIe driver,
>>> which is moved to DM right now.
>>>
>>> Signed-off-by: Stefan Roese <sr at denx.de>
>>> Cc: Bin Meng <bmeng.cn at gmail.com>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> ---
> 
> It's weird I did not receive this email in my inbox.

Hmm, strange.
  
>>>   include/pci.h | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/pci.h b/include/pci.h
>>> index 785d7d28b7..f4a9e025b3 100644
>>> --- a/include/pci.h
>>> +++ b/include/pci.h
>>> @@ -501,6 +501,7 @@ typedef int pci_dev_t;
>>>   #define PCI_BUS(d)             (((d) >> 16) & 0xff)
>>>   #define PCI_DEV(d)             (((d) >> 11) & 0x1f)
>>>   #define PCI_FUNC(d)            (((d) >> 8) & 0x7)
>>> +#define PCI_SLOT(d)            (((d) >> 3) & 0x1f)
>>
>> This seems unrelated to the other macros, since is shifts left only 3
>> positions. Can you perhaps move it to the end and add a comment as to
>> what the input is and what it returns? It seems different to the
>> others.
> 
> Agreed with Simon. Do you have any follow-up patches that will use
> this macro for better understanding?

Please see my comments on the last 2 mails and this PCI driver move
to DM:

http://patchwork.ozlabs.org/patch/1027268/

Thanks,
Stefan