[U-Boot] [PATCH v3 2/2] efi_selftest: fix variables test for GetNextVariableName()

[Heinrich Schuchardt]

On 1/22/19 10:24 AM, Alexander Graf wrote:
> 
> 
> On 21.01.19 12:43, Heinrich Schuchardt wrote:
>> From: AKASHI Takahiro <takahiro.akashi at linaro.org>
>>
>> There is a bug in efi variables test.
>> Fix it with some cosmetic improvements.
>>
>> Please note that efi variables test still fails at QueryVariableInfo()
>> and GetVariable(), but this is not due to a change in this patch.
>>   ==8<==
>>   Testing EFI API implementation
>>
>>   Selected test: 'variables'
>>
>>   Setting up 'variables'
>>   Setting up 'variables' succeeded
>>
>>   Executing 'variables'
>>   .../u-boot/lib/efi_selftest/efi_selftest_variables.c(60):
>>   TODO: QueryVariableInfo failed
>>   .../u-boot/lib/efi_selftest/efi_selftest_variables.c(131):
>>   TODO: GetVariable returned wrong length 7
>>   .../u-boot/lib/efi_selftest/efi_selftest_variables.c(133):
>>   TODO: GetVariable returned wrong value
>>   Executing 'variables' succeeded
>>
>>   Boot services terminated
>>
>>   Summary: 0 failures
>>   ==>8==
>>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
>> Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> 
> This fails in Travis for me on the qemu-x86_64 target:
> 
> /home/travis/build/agraf/u-boot/lib/efi_selftest/efi_selftest_variables.c(145):
> ERROR: GetNextVariableName failed (2)
> /home/travis/build/agraf/u-boot/lib/efi_selftest/efi_selftest.c(110):
> ERROR: Executing 'variables' failed
> 
> 
> Alex
> 
Hello Alex,

[PATCH 1/1] efi_loader: fix GetNextVariableName
https://lists.denx.de/pipermail/u-boot/2019-January/355811.html

offers a partial fix. Now we get the correct error code. There is still
something wrong in hexport_r(). It does not find a match for:

lib/hashtable.c(617) hexport_r:
ep->key efi_67029eb5-0af2-f6b1-da53-fcb566dd1ce6_efi_st_var0,
flag 272, argc 1, argv efi_.*-.*-.*-.*-.*_.*

Best regards

Heinrich