[U-Boot] [PATCH v3 0/5] subject: efi_loader: add HII database protocol

[Alexander Graf]

> Am 23.01.2019 um 06:11 schrieb AKASHI Takahiro <takahiro.akashi at linaro.org>:
> 
> Heinrich,
> 
>> On Tue, Jan 22, 2019 at 10:13:52PM +0100, Heinrich Schuchardt wrote:
>>> On 1/22/19 10:48 AM, Alexander Graf wrote:
>>> 
>>> 
>>>> On 21.01.19 04:12, AKASHI Takahiro wrote:
>>>> HII database protocol is the last missing (major?) piece of code so that
>>>> we can run unmodified EDKII's shell and UEFI SCT on EFI-enabled u-boot.
>>>> 
>>>> The original code was initially written by Leif and Rob a year ago[1],
>>>> and now I'm reworking it. The implementation has not been much
>>>> enhanced from the original, but I tried to give it clearer implementation
>>>> to be able to add more functionality easily later on.
>>>> I also addressed the comments by Alex[2] and added a self test on
>>>> request of Heinrich.
>>>> 
>>>> HII configuration routing protocol and access protocol have only
>>>> a skeleton and should be implemented when we need to have *drivers*
>>>> that require configuration mechanism.
>>> 
>>> Reviewed-by: Alexander Graf <agraf at suse.de>
>>> 
>>> But I'll wait for Heinrich's ok as well :)
>>> 
>>> 
>>> Alex
>>> 
>> I have seen that Takahiro has integrated my recent suggestions.
>> 
>> Currently I am still trying to understand what is wrong with
>> GetNextVariableName().
> 
> Thank you for finding and investigating this issue.
> I almost all of my time test my patches on arm64 primarily :)

Please always push your patch queues as braches to github and enable travis there. It will tell you quite conclusive test results, so that you don't break others targets by accident :).

Alex

> 
> -Takahiro Akashi
> 
>> So let's go with your review.
>> 
>> Best regards
>> 
>> Heinrich