[U-Boot] [PATCH] net: phy: realtek: Introduce quirk to mark RXC not stoppable

Joe Hershberger joe.hershberger at ni.com
Wed Jan 23 17:04:24 UTC 2019


On Wed, Jan 23, 2019 at 10:39 AM Carlo Caione <ccaione at baylibre.com> wrote:
>
> On 23/01/19 16:19, Joe Hershberger wrote:
>
> /cut
> >> +         transitions to/from a lower power consumption level (Low
> >> Power Idle
> >> +         mode) based on link utilization. When no packets are being
> >> +         transmitted, the system goes to Low Power Idle mode to save power.
> >> +
> >> +         Under particular circumstances this setting can cause issues where
> >> +         the PHY is unable to transmit or receive any packet when in LPI mode.
> >> +         The problem is caused when the PHY is configured to stop receiving
> >> +         the xMII clock while it is signaling LPI. When not stated otherwise
> >> +         this bit is set by libphy in the linux kernel.
> >
> >This seems to be copied from Linux, please update to describe what
> >happens in U-Boot.
>
> It is not copied from Linux. The problem is that the libphy in the
> kernel is flipping this bit and this is causing the issue in U-Boot on
> reboot. So I'm saying exactly that.

I see... you are saying it retains the value that may have be changed
by Linux. "When not stated otherwise" is to mean "If this config is
disabled" Should capitalize Linux.

>
> --
> Carlo Caione
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot


More information about the U-Boot mailing list