[U-Boot] [PATCH 3/3] linker: Modify linker scripts to be more generic

[Tom Rini]

On Thu, Jan 24, 2019 at 12:46:32PM +0100, Simon Goldschmidt wrote:
> On Tue, Jan 22, 2019 at 11:10 PM Tom Rini <trini at konsulko.com> wrote:
> >
> > Make use of "IMAGE_MAX_SIZE" and "IMAGE_TEXT_BASE" rather than
> > CONFIG_SPL_MAX_SIZE and CONFIG_SPL_TEXT_BASE.  This lets us re-use the
> > same script for both SPL and TPL.  Add logic to scripts/Makefile.spl to
> > pass in the right value when preprocessing the script.
> >
> > Cc: Stefano Babic <sbabic at denx.de>
> > Cc: Fabio Estevam <fabio.estevam at nxp.com>
> > Cc: Jagan Teki <jagan at openedev.com>
> > Cc: Maxime Ripard <maxime.ripard at bootlin.com>
> > Cc: Andreas Bießmann <andreas at biessmann.org>
> > Cc: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> > Cc: Michal Simek <monstr at monstr.eu>
> > Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> > Cc: York Sun <york.sun at nxp.com>
> > Cc: Bin Meng <bmeng.cn at gmail.com>
> > Cc: Heiko Schocher <hs at denx.de>
> > Cc: Adam Ford <aford173 at gmail.com>
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> 
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> 
> However, given that it's now "not allowed" to use OF_EMBED, how useful
> is the current size check? Because if done in the linker, it does not include
> the DTB.
> 
> I think we might need to move the MAX_SIZE check into the Makefile,
> much like CONFIG_BOARD_SIZE_LIMIT.

I was thinking about that too at one point and yes, there is follow-up
work to move that BOARD_SIZE_LIMIT code such that we don't have
multiple copies of it and hook more platforms into it.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190124/eeb5fe0b/attachment.sig>