[U-Boot] [PATCH] RFC: dfu: mmc: call fs functions instead of run_command

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Thu Jan 24 20:10:34 UTC 2019


Am Do., 24. Jan. 2019, 21:05 hat Stephen Warren <swarren at wwwdotorg.org>
geschrieben:

> On 1/24/19 11:38 AM, Simon Goldschmidt wrote:
> > This unbreaks dfu mmc_file_op which is currently broken since using the
> > load cmd on a buffer from heap is not allowed.
>
> Tested-by: Stephen Warren <swarren at nvidia.com>
>

That was fast, thanks!


> > diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c
>
> >   static int mmc_file_op(enum dfu_op op, struct dfu_entity *dfu,
> >                       void *buf, u64 *len)
> >   {
> > -     const char *fsname, *opname;
> > -     char cmd_buf[DFU_CMD_BUF_SIZE];
> > -     char *str_env;
> > +     char dev_part_str[DFU_CMD_BUF_SIZE];
>
> This can be a lot smaller now, but I guess it's fine as is.
>

This is why this is RFC. I wanted to find a way to prevent the conversion
to string and back first.

Regards,
Simon

>


More information about the U-Boot mailing list