[U-Boot] [PATCH v2 09/19] rockchip: evb_rk3399: Tidy up the README【请注意，邮件由3jd9gxammcg05wtpu41zv7z.14txr8r4.bn0t41px-puv25.p1z at chromium-sendgmr.bounces.google.com代发】

[Kever Yang]

Hi Simon,


On 01/22/2019 05:53 AM, Simon Glass wrote:
> Add mention of a prerequisite needed to build the image. Also adjust the
> English wording in a few places.
>
> Ideally this should move to using binman to produce images, and avoid the
> manual steps.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>

This patch look good to me.

Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>
> Changes in v2: None
>
>  board/rockchip/evb_rk3399/README | 33 ++++++++++++++++++++------------
>  1 file changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/board/rockchip/evb_rk3399/README b/board/rockchip/evb_rk3399/README
> index 8321467046..6469821987 100644
> --- a/board/rockchip/evb_rk3399/README
> +++ b/board/rockchip/evb_rk3399/README
> @@ -35,21 +35,29 @@ Get the Source and prebuild binary
>    > git clone https://github.com/rockchip-linux/rkbin.git
>    > git clone https://github.com/rockchip-linux/rkdeveloptool.git
>  
> -Compile the ATF
> -===============
> +Get some prerequisites
> +======================
> +
> +You need the Python elftools.elf.elffile library for make_fit_atf.py to work:
> +
> +  > sudo apt-get install python-pyelftools
> +
> +Compile ATF
> +===========
>  
>    > cd arm-trusted-firmware
>    > make realclean
>    > make CROSS_COMPILE=aarch64-linux-gnu- PLAT=rk3399 bl31
>  
> +  Get bl31.elf in this step, copy it to U-Boot root dir:
> +  > cp build/rk3399/release/bl31/bl31.elf ../u-boot/
> +
>    Or you can get the bl31.elf directly from Rockchip:
> -  cp rkbin/rk33/rk3399_bl31_v1.00.elf ../u-boot/bl31.elf
> +  > cp rkbin/rk33/rk3399_bl31_v1.00.elf ../u-boot/bl31.elf
>  
> -  Get bl31.elf in this step, copy it to U-Boot root dir:
> -  > cp bl31.elf ../u-boot/
>  
> -Compile the U-Boot
> -==================
> +Compile U-Boot
> +==============
>  
>    > cd ../u-boot
>    > export ARCH=arm64
> @@ -62,17 +70,18 @@ Compile the U-Boot
>  
>    Get spl/u-boot-spl.bin and u-boot.itb in this step.
>  
> -Compile the rkdeveloptool
> -=======================
> -  Follow instructions in latest README
> +Compile rkdeveloptool
> +=====================
> +
> +Get rkdeveloptool installed on your Host in this step.
> +
> +Follow instructions in latest README, example:
>    > cd ../rkdeveloptool
>    > autoreconf -i
>    > ./configure
>    > make
>    > sudo make install
>  
> -  Get rkdeveloptool in you Host in this step.
> -
>  Both origin binaries and Tool are ready now, choose either option 1 or
>  option 2 to deploy U-Boot.
>