[U-Boot] [PATCH 1/1] test/py: use default load address for tftp

Heinrich Schuchardt xypron.glpk at gmx.de
Sat Jan 26 16:25:54 UTC 2019


On 1/26/19 4:58 PM, Tom Rini wrote:
> On Sat, Jan 26, 2019 at 03:25:12PM +0100, Heinrich Schuchardt wrote:
>> On x86_64 the size of the file u-boot loaded by the tftp test has grown in
>> size such that when loading the file to 0x200000 it overwrites a memory
>> area reserved for PCI.
>>
>> If no load address is specified for tftp do not use the ram base address
>> (or if zero 0x200000) but the default adI dress.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>> Currently there is a bug in net/tftp.c introduced by commit a156c47e39ad
>> ("tftp: prevent overwriting reserved memory") which does not allow loading
>> to the second DRAM bank. Simon Goldschmidt is working to fix it.
> 
> Yes, a real bug and good job sorting it out.
> 
>> Due to this bug with the proposed patch we see a Travis CI error for
>> vexpress_ca15_tc2_defconfig and vexpress_ca9x4_defconfig.
> 
> It's breaking with whatever additional changes you're testing.  Please
> just put this change in your WIP branch until Simon has fixed the
> problem you've found.  Alternatively, fork uboot-test-hooks and make
> your WIP trees use that fork which specifies a different address to use
> for tftp?  Or am I missing something else? Thanks!
> 

I can well understand that you do not want to see this this patch merged
before Simon Goldschimidt's patch.

Maybe I should have also added a reference to this patch:

x86: #define CONFIG_LOADADDR 0x1100000
https://lists.denx.de/pipermail/u-boot/2019-January/356108.html

All three corrections are needed to let the efi-next patch queue
(https://github.com/agraf/u-boot/commits/efi-next) pass Travis CI testing.

Best regards

Heinrich


More information about the U-Boot mailing list