[U-Boot] [PATCH v3] arm64: mvebu: Add basic support for uDPU board

Stefan Roese sr at denx.de
Mon Jan 28 06:39:17 UTC 2019


On 25.01.19 18:04, Vladimir Vid wrote:
> This adds initial support for micro-DPU (uDPU) board which is based on Armada-3720 SoC.
> micro-DPU is the single-port FTTdp "distribution point unit" made by Methode Electronics
> which offers complete modularity with replaceable SFP modules both for uplink and downlink
> (G.hn over twisted-pair, G.hn over coax, 1G and 2.5G Ethernet over Cat-5e cable).
> 
> On-board features:
> - 512 MiB DDR3
> - 2 x 2.5G SFP via HSGMII SERDES interface to the A3720 SoC
> - USB 2.0 Type-C connector
> - 4GB eMMC
> - ETSI TS 101548 reverse powering via twisted pair (RJ45) or coax (F Type)
> 
> Cc: Luka Perkov <luka.perkov at sartura.hr>
> Cc: Luis Torres <luis.torres at methode.com>
> Cc: Scott Roberts <scott.roberts at telus.com>
> Cc: Paul Arola <paul.arola at telus.com>
> Cc: Chris Packham <judge.packham at gmail.com>
> 
> Signed-off-by: Vladimir Vid <vladimir.vid at sartura.hr>
> ---
> 
> v3 changes:
> - removed MMC_SDHCI_MV driver which was generating error durring the build.
> SDHCI_XENON driver is sufficient for the internal eMMC.
> - fixed remaining warnings durring the build time (reg properties)

Could you please add me on MVEBU related patches as I'm handling them?

One further comments below.
  
> ---
>   arch/arm/dts/Makefile                       |   1 +
>   arch/arm/dts/armada-3720-uDPU.dts           | 201 ++++++++++++++++++++
>   board/Marvell/mvebu_armada-37xx/MAINTAINERS |   5 +
>   configs/uDPU_defconfig                      |  94 +++++++++
>   4 files changed, 301 insertions(+)
>   create mode 100644 arch/arm/dts/armada-3720-uDPU.dts
>   create mode 100644 configs/uDPU_defconfig
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 5c3225bcbf..9e1e1ad8e9 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -95,6 +95,7 @@ dtb-$(CONFIG_ARCH_MVEBU) +=			\
>   	armada-3720-db.dtb			\
>   	armada-3720-espressobin.dtb		\
>   	armada-3720-turris-mox.dtb		\
> +	armada-3720-uDPU.dts			\
>   	armada-375-db.dtb			\
>   	armada-388-clearfog.dtb			\
>   	armada-388-gp.dtb			\
> diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts
> new file mode 100644
> index 0000000000..de44e317a6
> --- /dev/null
> +++ b/arch/arm/dts/armada-3720-uDPU.dts
> @@ -0,0 +1,201 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Device tree for the uDPU board.
> + * Based on Marvell Armada 3720 development board (DB-88F3720-DDR3)
> + * Copyright (C) 2016 Marvell
> + * Copyright (C) 2018 Methode
> + * Copyright (C) 2018 Telus
> + *
> + * Vladimir Vid <vladimir.vid at sartura.hr>
> + */
> +
> +/dts-v1/;
> +
> +#include "armada-37xx.dtsi"
> +
> +/ {
> +	model = "Methode uDPU Board";
> +	compatible = "methode,udpu";
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +		bootargs = "console=ttyMV0,115200 earlycon=ar3700_uart,0xd0012000";
> +	};
> +
> +	aliases {
> +		i2c0 = &i2c0;
> +		i2c1 = &i2c1;
> +		spi0 = &spi0;
> +	};
> +
> +	memory at 0 {
> +		device_type = "memory";
> +		reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
> +	};
> +
> +	mdio: mdio at 32004 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		ethphy0: ethernet-phy at 0 {
> +			 reg = <0>;
> +		};
> +		ethphy1: ethernet-phy at 1 {
> +			reg = <1>;
> +		};
> +	};
> +
> +	scsi: scsi {
> +		compatible = "marvell,mvebu-scsi";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		max-id = <1>;
> +		max-lun = <1>;
> +		status = "okay";
> +	};
> +
> +	i2c1: i2c at 11080 {
> +		compatible = "marvell,armada-3700-i2c", "simple-bus";
> +		reg = <0x0 0x11080 0x0 0x80>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&i2c2_pins>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		status = "okay";
> +	};
> +
> +	uart1: serial at 12200 {
> +		compatible = "marvell,armada-3700-uart-ext";
> +		reg = <0x0 0x12200 0x0 0x30>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&uart2_pins>;
> +		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> +		status = "okay";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +	};
> +
> +	vcc_sd_reg0: regulator at 0 {
> +		compatible = "regulator-gpio";
> +		regulator-name = "vcc_sd0";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-type = "voltage";
> +		states = <1800000 0x1
> +			3300000 0x0>;
> +		gpios = <&gpiosb 23 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	sfp_eth0: sfp-eth0 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&i2c0>;
> +		los-gpio = <&gpiosb 2 GPIO_ACTIVE_HIGH>;
> +		mod-def0-gpio = <&gpiosb 3 GPIO_ACTIVE_LOW>;
> +		tx-disable-gpio = <&gpiosb 4 GPIO_ACTIVE_HIGH>;
> +		tx-fault-gpio = <&gpiosb 5 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	sfp_eth1: sfp-eth1 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&i2c1>;
> +		sfp,ethernet = <&eth1>;
> +		los-gpio = <&gpiosb 7 GPIO_ACTIVE_HIGH>;
> +		mod-def0-gpio = <&gpiosb 8 GPIO_ACTIVE_LOW>;
> +		tx-disable-gpio = <&gpiosb 9 GPIO_ACTIVE_HIGH>;
> +		tx-fault-gpio = <&gpiosb 10 GPIO_ACTIVE_HIGH>;
> +	};
> +};
> +
> +&comphy {
> +	phy0 {
> +		phy-type = <PHY_TYPE_SGMII1>;
> +		phy-speed = <PHY_SPEED_1_25G>;
> +	};
> +        phy1 {
> +                phy-type = <PHY_TYPE_SGMII0>;
> +                phy-speed = <PHY_SPEED_1_25G>;
> +        };
> +
> +        phy2 {
> +                phy-type = <PHY_TYPE_USB3_HOST1>;
> +                phy-speed = <PHY_SPEED_5G>;
> +        };
> +};
> +
> +&eth0 {
> +	pinctrl-0 = <&pcie_pins>;
> +	status = "okay";
> +	phy-mode = "sgmii";
> +	phy = <&ethphy0>;
> +	fixed-link {
> +		speed = <1000>;
> +		full-duplex;
> +	};
> +};
> +
> +&eth1 {
> +	status = "okay";
> +	phy-mode = "sgmii";
> +	phy = <&ethphy1>;
> +	fixed-link {
> +		speed = <1000>;
> +		full-duplex;
> +	};
> +};
> +
> +&i2c0 {
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&i2c1_pins>;
> +        status = "okay";
> +};
> +
> +&spi0 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi_quad_pins>;
> +	u-boot,dm-pre-reloc;

Please move all those U-Boot specific DT properties (like "u-boot,dm-pre-reloc)
into a separate DT file. See for example:

arch/arm/dts/armada-388-clearfog-u-boot.dtsi

If names correctly, this file will get included by the U-Boot build system
automatically and the dts file can stay in sync with the original one from
Linux.

Thanks,
Stefan

Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list