[U-Boot] [PATCH v3 01/60] mpc83xx: Introduce ARCH_MPC830*

Mario Six mario.six at gdsys.cc
Mon Jan 28 08:13:52 UTC 2019


Hi York,
On Tue, Jan 22, 2019 at 5:17 PM York Sun <york.sun at nxp.com> wrote:
>
> On 1/21/19 12:19 AM, Mario Six wrote:
> > Replace CONFIG_MPC830* with proper CONFIG_ARCH_MPC830* Kconfig options.
> >
> > Signed-off-by: Mario Six <mario.six at gdsys.cc>
> >
> > ---
>
> I browse through the entire patch set. The patches look good. Since NXP
> doesn't make new mpc83xx SoCs and I have no board to verify, I don't
> comment on specific changes.
>
> There were many config macros which have been replace with hard-coded
> value inline by you. That's OK. The original plan was to allow different
> config but that didn't happen mostly.
>

Sounds good. Thanks for reviewing!

> York
>
Best regards,
Mario


More information about the U-Boot mailing list