[U-Boot] [PATCH 1/5] arm: socfpga: gen5: add reset handles to devicetrees

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Mon Jan 28 11:46:57 UTC 2019


On Mon, Jan 28, 2019 at 12:30 PM Marek Vasut <marex at denx.de> wrote:
>
> On 1/27/19 9:45 AM, Simon Goldschmidt wrote:
> > Am 26.01.2019 um 09:57 schrieb Marek Vasut:
> >> On 1/25/19 9:30 PM, Simon Goldschmidt wrote:
> >>> The SPL for socfpga gen5 currently takes all peripherals out of reset
> >>> unconditionally. To implement proper reset handling for peripherals,
> >>>   some device tree nodes are missing reset handles.
> >>>
> >>> Since the socfpga gen5 devicetrees are currently in sync with Linux
> >>> 4.20,
> >>> and these reset handles are not added to Linux, yet, let's add them to
> >>> U-Boot specific dtsi files to ease future merging.
> >>>
> >>> This adds a new file socfpga_u-boot.dtsi (note the '_' - if using a '-'
> >>> this file gets pulled in for some a10/s10 devicetrees) that adds the
> >>> missing reset handles.
> >>>
> >>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> >>
> >> Shouldn't all this be in u-boot specific DTs, instead of the ones
> >> imported from Linux ?
> >
> > The "u-boot,dm-pre-reloc" thing should of course stay in u-boot specific
> > DTs. But I had to add many missing "resets = " references that are yet
> > missing in upstream Linux DTs. Dinh is in the process of adding them and
> > I'll make sure to sync that back to U-Boot once it's in Linux mainline
> > git. I just did not want to wait until that happens...
>
> Maybe you can just submit this patch to Linux too ?

Dinh has already done that, that's why I have him in the loop here.
But his patch was missing some reset pins, so this would need another update.

Regards,
Simon


More information about the U-Boot mailing list