[U-Boot] [PATCH 07/10] clk: imx8: add i.MX8QM clk driver

Peng Fan peng.fan at nxp.com
Tue Jan 29 01:14:48 UTC 2019


Hi Stefano

> > +
> >
> 
> Ok - I see you decide to split the code on depend of the SOC type.
> Nevertheless, even if defines are different, it seems to me that there is still a
> lot of common code (_imx8_clk_enable is very similar). Do we need really a
> separate file for each MX8 variant ? Which are the blocking points that avoid
> to do this ? I am looking at the patch, but I do not find such as issue. Can you
> explain it ?

I do not want to mix i.MX8QXP and QM currently, although it looks most same logic except the macros.
Linux side code still not merged by upstream, there will be some change there I think. Then I think
uboot side code also need some restructure following Linux change.
Another one is there are many variants, not only QXP/QM, add all the macros in one file will make
it not elegant and end up of more and more ifdef in one file.

Thanks,
Peng.

> 
> Regards,
> Stefano
> 
> 
> --
> ==============================================================
> =======
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
> ==============================================================
> =======


More information about the U-Boot mailing list