[U-Boot] [PATCH u-boot 04/11] video: Add Meson Video Processing Unit Driver

[Neil Armstrong]

Hi Anatolij,

On 28/01/2019 20:56, Anatolij Gustschin wrote:
> On Tue, 15 Jan 2019 17:17:52 +0100
> Neil Armstrong narmstrong at baylibre.com wrote:
> 
>> This adds video output support for Amlogic GXBB/GXL/GXM chips.
>> The supported ports are CVBS and HDMI (based on DW_HDMI).
>>
>> When using HDMI, only DMT modes are supported.
>>
>> There is support for simple-framebuffer (CONFIG_VIDEO_DT_SIMPLEFB)
>>
>> Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>
>> Signed-off-by: Jorge Ramire-Ortiz <jramirez at baylibre.com>
>> Signed-off-by: Maxime Jourdan <mjourdan at baylibre.com>
> 
> Reviewed-by: Anatolij Gustschin <agust at denx.de>
> 
> Please see minor comment below.
> 
>> diff --git a/drivers/video/meson/meson_canvas.c b/drivers/video/meson/meson_canvas.c
> ...
>> +/* DMC Registers */
>> +#define DMC_CAV_LUT_DATAL	0x48 /* 0x12 offset in data sheet */
>> +#define CANVAS_WIDTH_LBIT	29
>> +#define CANVAS_WIDTH_LWID       3
>> +#define DMC_CAV_LUT_DATAH	0x4c /* 0x13 offset in data sheet */
>> +#define CANVAS_WIDTH_HBIT       0
>> +#define CANVAS_HEIGHT_BIT       9
>> +#define CANVAS_BLKMODE_BIT      24
>> +#define DMC_CAV_LUT_ADDR	0x50 /* 0x14 offset in data sheet */
>> +#define CANVAS_LUT_WR_EN        (0x2 << 8)
>> +#define CANVAS_LUT_RD_EN        (0x1 << 8)
> 
> Some define values are not aligned by tab here.

Thanks for reviewing,

I'll fix it.

Do you mind if I push this serie via the amlogic custodian ?

Tom is it ok for you ?

Neil

> 
> --
> Anatolij
>