[U-Boot] [PATCH v4 0/9] mmc: sunxi: Enable DM_MMC

[Andre Przywara]

On Tue, 29 Jan 2019 23:12:17 +0530
Jagan Teki <jagan at amarulasolutions.com> wrote:

Hi,

> On Tue, Jan 29, 2019 at 9:24 PM Andre Przywara
> <andre.przywara at arm.com> wrote:
> >
> > This series gathers all remaining patches we need to enable DM_MMC
> > for Allwinner boards. It relies on the clock gates framework
> > already merged, and adds the respective gates and resets for each
> > SoC. It then teaches the sunxi MMC driver to use the clock
> > framework for those reset and gates clocks. The "mod clock",
> > responsible for setting the actual interface speed, is still
> > handled in the MMC driver, as the DM_CLK part of that is not ready
> > yet (and is not trivial). This allows to turn on DM_MMC, and gets
> > rid of the doomsday warning message every Allwinner board was
> > blessed with for a while.
> >
> > This series is available at:
> > https://github.com/apritzel/u-boot/commits/sunxi-dm-gates
> >
> > ---------------------------
> >
> > Jagan, can you please have a look whether this is fine? If you are
> > not sure about patch 7, you can leave this one out for now.
> > If you are good with it, can you merge it to sunxi/master and send
> > the PR, so that it still goes into the release?
> > We can then fix all the remaining issues until the release.
> >
> > Cheers,
> > Andre.
> >
> > Changes in v4:
> > - Add proper A80 support (special MMC config clock)
> > - Add V3s support (gates and resets)
> > - Fix pinmux problem when not booting via SD or eMMC
> > - smaller fixes per ML discussion
> > Changes for v3:
> > - Handle clock via CLK framework.
> > Changes for v2:
> > - update the 'reset enablement' logic to do
> >   required SoC's
> >
> > Andre Przywara (5):
> >   sunxi: clk: enable clk and reset for CCU devices
> >   sunxi: clk: add MMC gates/resets
> >   sunxi: clk: A80: add MMC clock support
> >   mmc: sunxi: Add DM clk and reset support
> >   sunxi: board: do MMC pinmux setup for DM_MMC builds  
> 
> Does this fix any issue? not sure why is this part of DM_MMC? in fact
> I didn't see any issues.

This fixes boot via FEL or SPI flash, where the SPL won't setup the
pinmux for us. I should have mentioned that explicitly in the commit
message, sorry.

> >
> > Jagan Teki (4):
> >   mmc: sunxi: Add remaining compatible strings
> >   mmc: sunxi: Add DM_MMC support for H6
> >   arm: sunxi: Enable DM_MMC
> >   arm: dts: sunxi: Enumerate MMC2 as MMC1  
> 
> I have next version change for this? will replace.
> 
> patch [1] should be also be part of the DM_MMC w/o this SD is unable
> to detect in sopine boards.

I know, if you are OK with it, can you please add it to the series, at
best with your Reviewed-by? Otherwise we can still take it later as a
fix.

Thanks,
Andre

> [1] https://patchwork.ozlabs.org/patch/1027858/
> 
> Pritt, can you test the FEL that you mentioned on IRC?