[U-Boot] [PATCH v2 08/22] arm: dts: Add all the imx6[q|qp|dl] sabre[auto|sd] u-boot dts[i] files

Wed Jan 30 08:22:26 UTC 2019

On 19-01-29 13:33:54, Peng Fan wrote:
> Hi Abel,
> 
> > -----Original Message-----
> > From: Abel Vesa
> > Sent: 2019年1月29日 19:31
> > To: Tom Rini <trini at konsulko.com>; Fabio Estevam
> > <fabio.estevam at nxp.com>; u-boot at lists.denx.de; dl-uboot-imx
> > <uboot-imx at nxp.com>; Peng Fan <peng.fan at nxp.com>
> > Cc: Nitin Garg <nitin.garg at nxp.com>; Abel Vesa <abel.vesa at nxp.com>
> > Subject: [PATCH v2 08/22] arm: dts: Add all the imx6[q|qp|dl] sabre[auto|sd]
> > u-boot dts[i] files
> > 
> > This allows us to keep the basic dts[i] files up-to-date with the ones in kernel,
> > but at the same time allowing the u-boot to add its own properties to the
> > existing nodes.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa at nxp.com>
> > ---
> >  arch/arm/dts/imx6dl-sabreauto-u-boot.dtsi  |  6 ++++++
> >  arch/arm/dts/imx6dl-sabresd-u-boot.dtsi    |  6 ++++++
> >  arch/arm/dts/imx6q-sabreauto-u-boot.dtsi   |  6 ++++++
> >  arch/arm/dts/imx6q-sabresd-u-boot.dtsi     |  6 ++++++
> >  arch/arm/dts/imx6qdl-sabreauto-u-boot.dtsi | 23
> > +++++++++++++++++++++++
> >  arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi   | 14 ++++++++++++++
> >  arch/arm/dts/imx6qdl-u-boot.dtsi           |  4 ++--
> >  arch/arm/dts/imx6qp-sabreauto-u-boot.dtsi  |  6 ++++++
> >  arch/arm/dts/imx6qp-sabresd-u-boot.dtsi    |  6 ++++++
> >  9 files changed, 75 insertions(+), 2 deletions(-)  create mode 100644
> > arch/arm/dts/imx6dl-sabreauto-u-boot.dtsi
> >  create mode 100644 arch/arm/dts/imx6dl-sabresd-u-boot.dtsi
> >  create mode 100644 arch/arm/dts/imx6q-sabreauto-u-boot.dtsi
> >  create mode 100644 arch/arm/dts/imx6q-sabresd-u-boot.dtsi
> >  create mode 100644 arch/arm/dts/imx6qdl-sabreauto-u-boot.dtsi
> >  create mode 100644 arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi
> >  create mode 100644 arch/arm/dts/imx6qp-sabreauto-u-boot.dtsi
> >  create mode 100644 arch/arm/dts/imx6qp-sabresd-u-boot.dtsi
> > 
> > diff --git a/arch/arm/dts/imx6dl-sabreauto-u-boot.dtsi
> > b/arch/arm/dts/imx6dl-sabreauto-u-boot.dtsi
> > new file mode 100644
> > index 0000000..b3f5f2d
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6dl-sabreauto-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Jagan Teki <jagan at amarulasolutions.com>  */
> 
> Is this file copied from other places? Do you need to update Copyright?
> Same questions to the following files with Copyright.
> 

Oups, I took the icore implementation as example and forgot to
modify the copyright header. Will do in the next version.

> > +
> > +#include "imx6qdl-sabreauto-u-boot.dtsi"
> > diff --git a/arch/arm/dts/imx6dl-sabresd-u-boot.dtsi
> > b/arch/arm/dts/imx6dl-sabresd-u-boot.dtsi
> > new file mode 100644
> > index 0000000..e34cf3c
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6dl-sabresd-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Jagan Teki <jagan at amarulasolutions.com>  */
> > +
> > +#include "imx6qdl-sabresd-u-boot.dtsi"
> > diff --git a/arch/arm/dts/imx6q-sabreauto-u-boot.dtsi
> > b/arch/arm/dts/imx6q-sabreauto-u-boot.dtsi
> > new file mode 100644
> > index 0000000..b3f5f2d
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6q-sabreauto-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Jagan Teki <jagan at amarulasolutions.com>  */
> > +
> > +#include "imx6qdl-sabreauto-u-boot.dtsi"
> > diff --git a/arch/arm/dts/imx6q-sabresd-u-boot.dtsi
> > b/arch/arm/dts/imx6q-sabresd-u-boot.dtsi
> > new file mode 100644
> > index 0000000..e34cf3c
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6q-sabresd-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Jagan Teki <jagan at amarulasolutions.com>  */
> > +
> > +#include "imx6qdl-sabresd-u-boot.dtsi"
> > diff --git a/arch/arm/dts/imx6qdl-sabreauto-u-boot.dtsi
> > b/arch/arm/dts/imx6qdl-sabreauto-u-boot.dtsi
> > new file mode 100644
> > index 0000000..3995849
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6qdl-sabreauto-u-boot.dtsi
> > @@ -0,0 +1,23 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2019 NXP
> > + */
> > +
> > +#include "imx6qdl-u-boot.dtsi"
> > +
> > +/ {
> > +	aliases {
> > +		mmc0 = &usdhc3;
> > +	};
> > +};
> > +
> > +&usdhc3 {
> > +	no-1-8-v;
> > +	keep-power-in-suspend;
> > +	enable-sdio-wakeup;
> 
> You could drop the upper two lines. They are not used by U-Boot.
> 
> Regards,
> Peng.
> 
> > +	u-boot,dm-spl;
> > +};
> > +
> > +&pinctrl_usdhc3 {
> > +	u-boot,dm-spl;
> > +};
> > diff --git a/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi
> > b/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi
> > new file mode 100644
> > index 0000000..45f02b1
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi
> > @@ -0,0 +1,14 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2019 NXP
> > + */
> > +
> > +#include "imx6qdl-u-boot.dtsi"
> > +
> > +&usdhc3 {
> > +	u-boot,dm-spl;
> > +};
> > +
> > +&pinctrl_usdhc3 {
> > +	u-boot,dm-spl;
> > +};
> > diff --git a/arch/arm/dts/imx6qdl-u-boot.dtsi
> > b/arch/arm/dts/imx6qdl-u-boot.dtsi
> > index dffc21b..45ae2fa 100644
> > --- a/arch/arm/dts/imx6qdl-u-boot.dtsi
> > +++ b/arch/arm/dts/imx6qdl-u-boot.dtsi
> > @@ -7,11 +7,11 @@
> >  	soc {
> >  		u-boot,dm-spl;
> > 
> > -		aips-bus at 02000000 {
> > +		aips-bus at 2000000 {
> >  			u-boot,dm-spl;
> >  		};
> > 
> > -		aips-bus at 02100000 {
> > +		aips-bus at 2100000 {
> >  			u-boot,dm-spl;
> >  		};
> >  	};
> > diff --git a/arch/arm/dts/imx6qp-sabreauto-u-boot.dtsi
> > b/arch/arm/dts/imx6qp-sabreauto-u-boot.dtsi
> > new file mode 100644
> > index 0000000..b3f5f2d
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6qp-sabreauto-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Jagan Teki <jagan at amarulasolutions.com>  */
> > +
> > +#include "imx6qdl-sabreauto-u-boot.dtsi"
> > diff --git a/arch/arm/dts/imx6qp-sabresd-u-boot.dtsi
> > b/arch/arm/dts/imx6qp-sabresd-u-boot.dtsi
> > new file mode 100644
> > index 0000000..e34cf3c
> > --- /dev/null
> > +++ b/arch/arm/dts/imx6qp-sabresd-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Jagan Teki <jagan at amarulasolutions.com>  */
> > +
> > +#include "imx6qdl-sabresd-u-boot.dtsi"
> > --
> > 2.7.4
> 