[U-Boot] pinctrl: imx: Fix select input issue

sbabic at denx.de sbabic at denx.de
Wed Jan 30 09:05:21 UTC 2019


> The pinctrl supports to set any bit in input register on iMX6 if
> the MSB of input value is 0xff. But the driver uses signed int for
> input value, so when executing the codes below, it won't meet.
> Because this is arithmetic right shift.
>     if (input_val >> 24 == 0xff)
> Fix the issue by changing the input_val, config_val and mux_mode to u32.
> Signed-off-by: Ye Li <ye.li at nxp.com>
> Reviewed-by: Fugang Duan <fugang.duan at nxp.com>
> Reviewed-by: Peng Fan <peng.fan at nxp.com>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================



More information about the U-Boot mailing list