[U-Boot] [PATCH v3 02/20] bitops: Fix GENMASK definition for Sandbox

Vignesh R vigneshr at ti.com
Thu Jan 31 13:34:44 UTC 2019



On 31/01/19 6:11 AM, Simon Glass wrote:
> On Mon, 28 Jan 2019 at 22:49, Vignesh R <vigneshr at ti.com> wrote:
>>
>> In arch/sandbox/include/asm/types.h we have
>> Therefore for 32 bit Sandbox build BITS_PER_LONG turns out to be 32 as
>> CONFIG_PHYS64 is not set
>>
>> This messes up the current logic of GENMASK macro due to mismatch b/w
>> size of unsigned long (64 bit) and that of BITS_PER_LONG.
>> Fix this by using CONFIG_SANDBOX_BITS_PER_LONG which is set to 64/32
>> based on the host machine on which its being compiled.
>>
>> Without this patch:
>> GENMASK(14,0) => 0x7fffffffffff
>> After this patch:
>> GENMASK(14,0) => 0x7fff
>>
>> Signed-off-by: Vignesh R <vigneshr at ti.com>
>> ---
>>  include/linux/bitops.h | 5 +++++
>>  1 file changed, 5 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 

I realised this patch is already merged to u-boot-dm when I posted it as
an RFC. Please ignore. Thanks!

-- 
Regards
Vignesh


More information about the U-Boot mailing list