[U-Boot] [PATCH 9/9] mmc: sunxi: Mark end of DM_MMC #ifdefs

Andre Przywara andre.przywara at arm.com
Thu Jan 31 14:55:20 UTC 2019


On Thu, 31 Jan 2019 03:04:21 -0700
Simon Glass <sjg at chromium.org> wrote:

> Hi Andre,
> 
> On Fri, 18 Jan 2019 at 18:33, Andre Przywara <andre.przywara at arm.com>
> wrote:
> >
> > The Allwinner MMC supports both the legacy approach and the driver
> > model, at the cost of quite some #ifdefs.
> >
> > Mark the closing #endifs with their respective config symbol, to
> > make it more obvious where each part ends and begins.
> >
> > Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> > ---
> >  drivers/mmc/sunxi_mmc.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)  
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> We should be able to remove the non-DM_MMC code now.

Unfortunately not, since the SPL still uses the legacy interface. Not
sure we can easily fix that without blowing up the code, given that the
64-bit SPL is REALLY tight.
If you are around in Brussels on the weekend, we can have a chat about
that.

Cheers,
Andre.




More information about the U-Boot mailing list