[U-Boot] [PATCH v3 00/22] mx6sabre: Add DM and SPL FIT support

[Tom Rini]

On Thu, Jan 31, 2019 at 03:13:51PM +0000, Abel Vesa wrote:
> On 19-01-31 09:41:11, Tom Rini wrote:
> > On Thu, Jan 31, 2019 at 12:59:19PM +0000, Abel Vesa wrote:
> > > On 19-01-30 13:58:19, Tom Rini wrote:
> > > > On Wed, Jan 30, 2019 at 01:39:50PM +0000, Abel Vesa wrote:
> > > > 
> > > > > The second version is here:
> > > > > https://lists.denx.de/pipermail/u-boot/2019-January/356557.html
> > > > > 
> > > > > Changes since v2:
> > > > >  * Removed the unecessary SYS_MALLOC_F_LEN from both defocnfig
> > > > >  * Fixed the copyright for all the *u-boot.dtsi files
> > > > 
> > > > OK, but you didn't answer why you need to specify your own its file when
> > > > the TI examples show how to have mkimage generate this for you, thanks!
> > > > 
> > > 
> > > I might be wrong here but TI is doing this for MLO, which AFAIU, it's for
> > > SPL. The fit_spl.its I'm adding here is actually for u-boot proper.
> > > 
> > > SPL expects descriptions in the configurations and that can't be done
> > > without its file, again, AFAIK.
> > > 
> > > Please let me know what exactly am I missing here.
> > 
> > The flag to mkimage is not about SPL but rather "create a single
> > configurations its file on the fly".  This should also be fine for the
> > its file in patch 10/22 (of v2, don't have v3 in front of me in
> > patchwork).
> > 
> 
> Well, I tried something like this (manually):
> 
> $ ./tools/mkimage -f auto -C none -A ARM -T standalone -a 0x17800000 -e 0x17800000 -d u-boot-fit-dtb.bin -n "U-Boot" u-boot.itb -E
> 
> and the output was:
> 
> FIT description: Standalone Program image with one or more FDT blobs                  
> Created:         Thu Jan 31 13:58:01 2019                                             
>  Image 0 (standalone-1)                                                               
>   Description:  U-Boot                                                                
>   Created:      Thu Jan 31 13:58:01 2019                                              
>   Type:         Standalone Program                                                    
>   Compression:  uncompressed                                                          
>   Data Size:    646400 Bytes = 631.25 KiB = 0.62 MiB                                  
>   Architecture: ARM                                                                   
>   Load Address: 0x17800000                                                            
>   Entry Point:  0x17800000                                                            
>  Default Configuration: 'conf-1'                                                      
>  Configuration 0 (conf-1)                                                             
>   Description:  unavailable                                                           
>   Kernel:       unavailable                                                           
> 
> And then the SPL complains about the configuration description:
> 
> U-Boot SPL 2019.01-00374-gbe79a83 (Jan 31 2019 - 13:56:01 +0200)
> Trying to boot from MMC1
> fit_find_config_node: Missing FDT description in DTB
> No matching DT out of these options:
>    Firmware image with one or more FDT blobs
> fit_find_config_node: Missing FDT description in DTB
> No matching DT out of these options:
>    Firmware image with one or more FDT blobs
> fit_find_config_node: Missing FDT description in DTB
> No matching DT out of these options:
>    Firmware image with one or more FDT blobs
> mmc_load_image_raw_sector: mmc block read error
> spl: no partition table found
> SPL: failed to boot from all boot devices
> ### ERROR ### Please RESET the board ###
> 
> But with the fit_spl.its file I added I have this and works:
> 
> FIT description: Image for u-boot proper (with dtb appended)    
> Created:         Thu Jan 31 13:57:02 2019                       
>  Image 0 (uboot at 1)                                              
>   Description:  U-Boot                                          
>   Created:      Thu Jan 31 13:57:02 2019                        
>   Type:         Standalone Program                              
>   Compression:  uncompressed                                    
>   Data Size:    646400 Bytes = 631.25 KiB = 0.62 MiB            
>   Architecture: ARM                                             
>   Load Address: 0x17800000                                      
>   Entry Point:  unavailable                                     
>  Default Configuration: 'conf at 1'                                
>  Configuration 0 (conf at 1)                                       
>   Description:  i.MX armv7                                      
>   Kernel:       unavailable                                     
>   Loadables:    uboot at 1                                         
> 
> So the differences between this and the one generated with mkimage+flags
> are the loadables and the description in the configuration 0.
> 
> Can I specify those through flags ?

Off the top of my head, I'm not sure what's going on, but thanks for
digging at it more.  I would say that this case not working is a bug,
not a feature, so please figure out what's needed such that mkimage does
the right thing in this case.  The intention is that for a single
configuration FIT we should not have to write the its file by hand.
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190131/de5c3828/attachment.sig>