[U-Boot] [PATCH v3 2/2] xilinx_xiic: Fix transfer initialisation

Melin Tomas tomas.melin at vaisala.com
Mon Jul 1 06:04:27 UTC 2019


Hello Heiko,

On 6/28/19 3:43 PM, Heiko Schocher wrote:
>
> I fixed that, also this and patch 1/2 has some style issues:
>
> ERROR: Please use git commit description style 'commit <12+ chars of 
> sha1> ("<title line>")' - ie: 'commit fatal: mehrd ("1': unbekannter 
> Commit oder Pfad existiert nicht")'
> #127:
> For reference, see linux kernel commit: 9656eeebf3f1 ("i2c: Revert

FWIW, I did run checkpatch on these patches prior to sending, with no 
findings. Do you have some stricter settings or what might be the reason?


>
>
> ERROR: DOS line endings
> #165: FILE: drivers/i2c/xilinx_xiic.c:282:
> +^M$
>
> total: 13 errors, 0 warnings, 0 checks, 20 lines checked
>
> patch 1/2:
> ERROR: DOS line endings
> #147: FILE: drivers/i2c/xilinx_xiic.c:152:
> +^I^Iif ((msg->len - pos == 0) && nmsgs == 1) {^M$

Strange, I don't see these errors either.


>
> I fixed them too, see:
> https://github.com/hsdenx/u-boot-i2c/commits/devel
>
> travis build started:
> https://travis-ci.org/hsdenx/u-boot-i2c/builds/551762033
>
> If there is a need for v4 please use them as base, thanks!

Looks as it passed, thanks!

Tomas




More information about the U-Boot mailing list