[U-Boot] [PATCH 0/2] tools: mkenvimage: Fixes for reading from pipes

Tom Rini trini at konsulko.com
Mon Jul 1 13:23:26 UTC 2019


On Mon, Jul 01, 2019 at 10:22:46AM +0100, Andre Przywara wrote:
> On Sun, 30 Jun 2019 10:40:44 -0400
> Tom Rini <trini at konsulko.com> wrote:
> 
> Hi Tom,
> 
> > On Sun, Jun 30, 2019 at 02:44:59AM +0100, Andre Przywara wrote:
> > 
> > > This fixes two issues I had when trying to create an envimage from a
> > > more complex pipe:
> > > - The read process stops when the read(2) syscall returns less bytes
> > >   than requested.
> > > - Specifying an input filename expects this to be a regular file.
> > > 
> > > See the respective commit messages for more details.
> > > 
> > > Thanks!
> > > Andre
> > > 
> > > Andre Przywara (2):
> > >   tools: mkenvimage: Fix reading from slow pipe
> > >   tools: mkenvimage: Always consider non-regular files
> > > 
> > >  tools/mkenvimage.c | 71 ++++++++++++++++--------------------------------------
> > >  1 file changed, 21 insertions(+), 50 deletions(-)  
> > 
> > These all look fine but in the interest of avoiding unintended
> > consequences I'm going to pull these in after v2019.07 as they're
> > long-standing bugs rather than regressions being fixed, thanks!
> 
> Thanks, that was my intention anyway.
> 
> So is the development model now "only send new changes/features in the
> merge window"? I was suspecting that with this new long stabilisation
> phase we prepare patches outside of the merge window?
> Or was the "Fixes ..." in the subject line giving the wrong impression
> of my intention?

New changes / features should still be posted when they're ready for
public review, to get the most possible review done to them.  I just
figured that since this was a series that was fixing a problem I should
give it a look and since I could see an argument in favor of merging
them now, say why I wasn't.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190701/1d9b6087/attachment.sig>


More information about the U-Boot mailing list