[U-Boot] [PATCH 18/26] binman: Use the cbfs memlen field only for uncompressed length
Simon Glass
sjg at chromium.org
Tue Jul 2 00:24:47 UTC 2019
The purpose of this badly named field is a bit ambiguous. Adjust the code
to use it only to store the uncompressed length of a file, leaving it set
to None if there is no compression used. This makes it easy to see if the
value in this field is relevant / useful.
Also set data_len for compressed fields, since it should be the length of
the compressed data, not the uncompressed data.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
tools/binman/cbfs_util.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tools/binman/cbfs_util.py b/tools/binman/cbfs_util.py
index 530629a5c96..4691be4aee2 100644
--- a/tools/binman/cbfs_util.py
+++ b/tools/binman/cbfs_util.py
@@ -197,7 +197,8 @@ class CbfsFile(object):
data_len: Length of (possibly compressed) data in bytes
ftype: File type (TYPE_...)
compression: Compression type (COMPRESS_...)
- memlen: Length of data in memory (typically the uncompressed length)
+ memlen: Length of data in memory, i.e. the uncompressed length, None if
+ no compression algortihm is selected
load: Load address in memory if known, else None
entry: Entry address in memory if known, else None. This is where
execution starts after the file is loaded
@@ -213,11 +214,11 @@ class CbfsFile(object):
self.data = data
self.ftype = ftype
self.compress = compress
- self.memlen = len(data)
+ self.memlen = None
self.load = None
self.entry = None
self.base_address = None
- self.data_len = 0
+ self.data_len = len(data)
self.erase_byte = None
self.size = None
@@ -349,9 +350,11 @@ class CbfsFile(object):
data = tools.Compress(orig_data, 'lz4')
elif self.compress == COMPRESS_LZMA:
data = tools.Compress(orig_data, 'lzma')
+ self.memlen = len(orig_data)
+ self.data_len = len(data)
attr = struct.pack(ATTR_COMPRESSION_FORMAT,
FILE_ATTR_TAG_COMPRESSION, ATTR_COMPRESSION_LEN,
- self.compress, len(orig_data))
+ self.compress, self.memlen)
elif self.ftype == TYPE_EMPTY:
data = tools.GetBytes(self.erase_byte, self.size)
else:
--
2.22.0.410.gd8fdbe21b5-goog
More information about the U-Boot
mailing list