[U-Boot] [PATCH 1/3] ARM: dts: dh-imx6: Refactor DT with som and board level defs for use with imx6 duallite

[Marek Vasut]

On 7/2/19 10:45 AM, Ludwig Zenz wrote:
> To use the device tree definitions imx6q-dhcom-som.dtsi for all imx6 derivatives rename
> it to imx6qdl-dhcom.dtsi. We omit the '-som', because it simplifies further mainlinening
> of already existing device trees.
> To reuse board level common stuff imx6qdl-dhcom-pdk2.dtsi is created and included by
> imx6q-dhcom-pdk2.dts.
> 
> Signed-off-by Ludwig Zenz <lzenz at dh-electronics.com>
> ---

You forgot a changelog here:

V2: - foo changed
    - bar was adjusted ...

Also, $subject should state [PATCH v2 ...

>  arch/arm/dts/imx6q-dhcom-pdk2.dts                  | 143 +--------------------
>  arch/arm/dts/imx6qdl-dhcom-pdk2.dtsi               | 140 ++++++++++++++++++++
>  .../{imx6q-dhcom-som.dtsi => imx6qdl-dhcom.dtsi}   |   1 -
>  3 files changed, 146 insertions(+), 138 deletions(-)
>  create mode 100644 arch/arm/dts/imx6qdl-dhcom-pdk2.dtsi
>  rename arch/arm/dts/{imx6q-dhcom-som.dtsi => imx6qdl-dhcom.dtsi} (99%)
> 
> diff --git a/arch/arm/dts/imx6q-dhcom-pdk2.dts b/arch/arm/dts/imx6q-dhcom-pdk2.dts
> index 9c61e3be2d..49ef3552bd 100644
> --- a/arch/arm/dts/imx6q-dhcom-pdk2.dts
> +++ b/arch/arm/dts/imx6q-dhcom-pdk2.dts
> @@ -1,151 +1,20 @@
>  // SPDX-License-Identifier: (GPL-2.0+)
>  /*
> - * Copyright (C) 2015 DH electronics GmbH
> - * Copyright (C) 2018 Marek Vasut <marex at denx.de>
> + * Copyright (C) 2019 DH electronics GmbH

Please don't remove my copyright ? Also, extend the DH copyright (2015-2019)

>   */
>  
>  /dts-v1/;
>  
> -#include "imx6q-dhcom-som.dtsi"
> +#include "imx6q.dtsi"
> +#include "imx6qdl-dhcom.dtsi"

Shouldn't #include "imx6qdl-dhcom.dtsi" be in #include
"imx6qdl-dhcom-pdk2.dtsi" instead ?

[...]

-- 
Best regards,
Marek Vasut