[U-Boot] [RESEND PATCH v3 13/18] usb: dwc3: Kconfig: get rid of obsolete mode selection

Marek Vasut marex at denx.de
Tue Jul 2 12:10:53 UTC 2019


On 7/2/19 2:06 PM, Jean-Jacques Hiblot wrote:
> 
> On 02/07/2019 13:38, Marek Vasut wrote:
>> On 7/2/19 4:11 AM, Kever Yang wrote:
>>>
>>> On 06/27/2019 09:06 PM, Jean-Jacques Hiblot wrote:
>>>> The mode selection for the DWC3 is kind of obsolete. The driver does
>>>> not
>>>> have to be host only or gadget only. This choice is confusing.
>>>> All the remaining callers of dwc3_uboot_init() explicitly set dr_mode
>>>> before calling the function, so none rely on a default behavior.
>>>>
>>>> Remove the choice menu and keep only the USB_DWC3_GADGET option.
>>>> Enable it
>>>> by default if USB_GADGET and USB_DWC3 are enabled.
>>>> It must be disabled for the evb-rk3328 as it uses DWC2 for the
>>>> gadget and
>>>> DWC3 for the host.
>>>>
>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>>> Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
>> So is this a fix for current release or feature for next ? I take it
>> it's the later.
>>
> I think this is more the former. I should have changed the title of the
> series to "Fix the DWC3 generic driver"
> 
> In the current release all the platforms relying on the dwc3-generic
> driver are broken because of the usage of MISC uclass.
> 
> This series among other things fixes it.

Are you able to somehow reduce this to a smaller fix for current release ?

I see I have this series applied for -next now.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list