[U-Boot] [PATCH] fastboot: Add "is-userspace" variable

Sam Protsenko semen.protsenko at linaro.org
Wed Jul 3 15:56:44 UTC 2019


Hi Eugeniu,

On Fri, Jun 21, 2019 at 5:16 PM Eugeniu Rosca <erosca at de.adit-jv.com> wrote:
>
> Hi Sam,
>
> Two nits as input for future patches. No real concerns. Thanks!
>
> On Thu, Jun 20, 2019 at 04:40:26PM +0300, Sam Protsenko wrote:
> > As per documentation [1], Android-Q requires for bootloader to provide
> > "is-userspace" variable. "no" value should be always returned. This
> > patch implements this fastboot variable.
> >
> > [1] https://android.googlesource.com/platform/system/core/+/master/fastboot/README.md#client-variables
>
> This reference is floating, since it uses a branch name.
>

Will be fixed in next version.

> >
> > Signed-off-by: Sam Protsenko <semen.protsenko at linaro.org>
>
> The title could be more specific: `fastboot: getvar: *`.
>

Will be fixed in next version. Thanks for the review!

> Reviewed-by: Eugeniu Rosca <erosca at de.adit-jv.com>
>
> Thanks!
>
> --
> Best Regards,
> Eugeniu.


More information about the U-Boot mailing list