[U-Boot] [PATCH v2 2/9] usb: sl811-hcd: return -ENOTSUPP from unimplemented submit_int_msg

Marek Vasut marex at denx.de
Thu Jul 4 19:05:26 UTC 2019


On 7/4/19 8:54 PM, Michal Suchánek wrote:
> On Thu, 4 Jul 2019 18:19:20 +0200
> Marek Vasut <marex at denx.de> wrote:
> 
>> On 7/4/19 6:00 PM, Michal Suchánek wrote:
>>> On Tue, 2 Jul 2019 23:20:52 +0200
>>> Marek Vasut <marex at denx.de> wrote:
>>>   
>>>> On 7/2/19 9:35 PM, Michal Suchánek wrote:  
>>>>> On Tue, 2 Jul 2019 20:41:04 +0200
>>>>> Marek Vasut <marex at denx.de> wrote:
>>>>>     
>>>>>> On 7/2/19 7:55 PM, Michal Suchanek wrote:
>>>>>>
>>>>>> Commit message is still missing ...
>>>>>>    
>>>>>>> Signed-off-by: Michal Suchanek <msuchanek at suse.de>      
>>>>>> [...]    
>>>>>
>>>>> It says "usb: sl811-hcd: return -ENOTSUPP from unimplemented
>>>>> submit_int_msg"    
>>>>
>>>> That's subject, not commit message.  
>>>
>>> Should I add a dot like in bugzilla when it insists "you must add a
>>> comment for this change"?  
>>
>> Please add a commit message which explains the change.
>>
>> [...]
> 
> Which is "usb: sl811-hcd: return -ENOTSUPP from unimplemented
> submit_int_msg" 

That is subject. Until this is fixed, consider this patch NAKed.

https://www.denx.de/wiki/U-Boot/Patches#General_Patch_Submission_Rules
clearly states that meaningful commit message is mandatory.


More information about the U-Boot mailing list