[U-Boot] [PATCH v2 5/9] usb: storage: submit_int_msg -> usb_int_msg

Bin Meng bmeng.cn at gmail.com
Fri Jul 5 01:34:01 UTC 2019


On Fri, Jul 5, 2019 at 12:01 AM Michal Suchánek <msuchanek at suse.de> wrote:
>
> On Wed, 3 Jul 2019 09:39:10 +0800
> Bin Meng <bmeng.cn at gmail.com> wrote:
>
> > On Wed, Jul 3, 2019 at 1:57 AM Michal Suchanek <msuchanek at suse.de> wrote:
> > >
> > > Use the wrapper because the unwrapped function prototype will be changed
> > > in the following patch.
> > >
> > > Signed-off-by: Michal Suchanek <msuchanek at suse.de>
> > > ---
> > > v2: usb_submit_int_msg -> usb_int_msg
> > > ---
> > >  common/usb_storage.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/common/usb_storage.c b/common/usb_storage.c
> > > index 8c889bb1a648..7be965964f09 100644
> > > --- a/common/usb_storage.c
> > > +++ b/common/usb_storage.c
> > > @@ -650,7 +650,7 @@ static int usb_stor_CBI_get_status(struct scsi_cmd *srb, struct us_data *us)
> > >         int timeout;
> > >
> > >         us->ip_wanted = 1;
> > > -       submit_int_msg(us->pusb_dev, us->irqpipe,
> > > +       usb_int_msg(us->pusb_dev, us->irqpipe,
> > >                         (void *) &us->ip_data, us->irqmaxp, us->irqinterval);
> >
> > Please also change the indentation here.
>
> I prefer to not reindent lines I would not need to touch otherwise.

We need keep code conform with our coding standard. So please change that.

Regards,
Bin


More information about the U-Boot mailing list