[U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error

[Christoph Müllner]

Hi Andy,

On 05.07.19 12:06, Andy Yan wrote:
> Hi  Christoph:
> 
> On 2019/7/5 下午5:15, Christoph Müllner wrote:
>>
>> On 04.07.19 11:44, Andy Yan wrote:
>>> Commit b238e4b00ced ("rockchip: Cleanup of make_fit_atf.py.") set
>>> firmware = "atf_1";
>>> loadables = "uboot","atf_1","atf_2";
>>>
>>> Actually it should be:
>>> firmware = "atf_1";
>>> loadables = "uboot","atf_2","atf_3";
>> Does "atf_1" not need to be among loadables as well?
>> My version of the script produces:
>>
>> loadables = "uboot","atf_1","atf_2","atf_3";
> 
> Will you please provide your ble31.elf ?

I use mainline ATF (https://github.com/ARM-software/arm-trusted-firmware)
without any additional changes.

The bl31.elf/ATF can be built with the following instructions:

  make CROSS_COMPILE=aarch64-linux-gnu- PLAT=rk3399 bl31

Last time I used commit 8917380a for testing:
https://github.com/ARM-software/arm-trusted-firmware/commit/8917380a

I will provide a download link for the ELF file
in a follow-up off-list email to you.

Thanks,
Christoph

> 
> The current u-boot mainline(your version) produces :
> 
> loadables = "uboot","atf_1","atf_2";
> 
> from [0]
> [0]https://github.com/rockchip-linux/rkbin/blob/master/bin/rk33/rk3399_bl31_v1.28.elf
> 
>>
>> And with that I was able to boot mainline ATF.
>>
>>> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>>> ---
>>>
>>>   arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-rockchip/make_fit_atf.py b/arch/arm/mach-rockchip/make_fit_atf.py
>>> index 45ec105887..db0ae96ca8 100755
>>> --- a/arch/arm/mach-rockchip/make_fit_atf.py
>>> +++ b/arch/arm/mach-rockchip/make_fit_atf.py
>>> @@ -94,7 +94,7 @@ def append_conf_section(file, cnt, dtname, segments):
>>>       if segments != 0:
>>>           file.write(',')
>>>       for i in range(1, segments):
>>> -        file.write('"atf_%d"' % (i))
>>> +        file.write('"atf_%d"' % (i + 1))
>>>           if i != (segments - 1):
>>>               file.write(',')
>>>           else:
>>>
>>
>>
> 
>