[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

Sam Protsenko semen.protsenko at linaro.org
Mon Jul 8 12:54:15 UTC 2019


On Sat, Jul 6, 2019 at 11:32 PM Sam Protsenko
<semen.protsenko at linaro.org> wrote:
>
> Hi Simon,
>
> On Sat, Jul 6, 2019 at 7:53 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > Hi,
> >
> > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko <semen.protsenko at linaro.org> wrote:
> > >
> > > Signed-off-by: Sam Protsenko <semen.protsenko at linaro.org>
> > > ---
> > >  test/py/tests/{ => test_android}/test_avb.py | 0
> > >  1 file changed, 0 insertions(+), 0 deletions(-)
> > >  rename test/py/tests/{ => test_android}/test_avb.py (100%)
> > >
> > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py
> > > similarity index 100%
> > > rename from test/py/tests/test_avb.py
> > > rename to test/py/tests/test_android/test_avb.py
> > > --
> >
> > I'd prefer to keep tsts in one place. What is the goal of this patch?
> >
>
> It was me who asked Igor to make that change. I thought it would be
> convenient to keep all Android related tests in one place (for now
> it's AVB and A/B tests), so that:
>   1. We can tell which ones are Android related
>   2. We can run all Android tests with one command
>
> As I understand, it doesn't break anything. I got the idea from
> test_fs/ I guess. If you oppose this change, we can just drop it.
>

Sorry, I confused this one with Igor Opaniuk patch from A/B patch
series, where he adds the test for A/B, in test_android/ directory. I
thought it was good idea to keep everything Android-related in
separate namespace. If you want to keep all patches in one place, we
can do that, but Igor will need to re-send his A/B patch series once
again.

> Thanks!
>
> > Regards,
> > Simon
> >
> >
> > > 2.20.1
> > >


More information about the U-Boot mailing list