[U-Boot] [PATCH] net: phy: ti: Fix clock output DT property

Joseph Hershberger joseph.hershberger at ni.com
Mon Jul 8 19:25:32 UTC 2019


> -----Original Message-----
> From: Trent Piepho <tpiepho at impinj.com>
> Sent: Friday, May 10, 2019 12:49 PM
> To: u-boot at lists.denx.de
> Cc: Trent Piepho <tpiepho at impinj.com>; Joseph Hershberger
> <joseph.hershberger at ni.com>; Janine Hagemann
> <j.hagemann at phytec.de>; Grygorii Strashko <grygorii.strashko at ti.com>
> Subject: [EXTERNAL] [PATCH] net: phy: ti: Fix clock output DT property
> 
> The code block reading the DT property for the clock output control was
> before the phy's DT node pointer was set, so it could never work.  Move it
> after the node pointer is set.
> 
> Also store the unsigned 32-bit property into an unsigned value, not a signed
> value, as the former will cause a problem if value overflows.
> For instance, if one were to add 0xffffffff as a code to mean the clock output
> should be turned off.
> 
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Janine Hagemann <j.hagemann at phytec.de>
> Cc: Grygorii Strashko <grygorii.strashko at ti.com>
> Signed-off-by: Trent Piepho <tpiepho at impinj.com>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list