[U-Boot] [PATCH] FIX: ARM: IMX: Add compatible 'fsl, imx53-uart' to NXP's serial driver

[Marek Vasut]

On 7/9/19 5:06 PM, Lukasz Majewski wrote:
> Hi Marek,
> 
>> On 7/9/19 4:04 PM, Lukasz Majewski wrote:
>>> This patch fixes not enabled uart2 (and hence serial console) on
>>> i.MX53 devices. After following commit 1d255904c306 ("ARM: dts:
>>> imx: imx53: Synchronize iMX53 DT with Linux") from the uart2
>>> compatible the 'fsl,imx7d-uart' has been removed (which was
>>> correct).
>>>
>>> However, the root cause of the problem was the commit 98d62e618bb9
>>> ("arm: imx: add i.MX53 Beckhoff CX9020 Embedded PC") which
>>> introduced this compatible.
>>>
>>> Moreover, without this patch all i.MX53 UARTs are not usable as
>>> neither 'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs
>>> in drivers/serial/serial_mxc.c file.
>>>
>>> The fix is to add 'fsl,imx53-uart' as a compatible for the
>>> aforementioned serial driver (it is also defined in the Linux
>>> kernel).
>>>
>>> Signed-off-by: Lukasz Majewski <lukma at denx.de>  
>>
>> The tags in subject should be "serial: mxc: ..."
>>
>>> ---
>>>
>>>  drivers/serial/serial_mxc.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/serial/serial_mxc.c
>>> b/drivers/serial/serial_mxc.c index a435e68005..af40576f66 100644
>>> --- a/drivers/serial/serial_mxc.c
>>> +++ b/drivers/serial/serial_mxc.c
>>> @@ -342,6 +342,7 @@ static int mxc_serial_ofdata_to_platdata(struct
>>> udevice *dev) }
>>>  
>>>  static const struct udevice_id mxc_serial_ids[] = {  
>>
>> Add fsl,imx21-uart to catch all the remaining cases ?
>>
> 
> I've posted v2 of this patch.
> 
> Just one question - I've noticed that there was some work done for
> m53 menlo board. It seems like it could be affected by this issue (if it
> uses serial console in u-boot). 
Odd, when I tested it, I had no problem with serial console, but it
would make sense that it is affected. I'll take a look.

[...]