[U-Boot] [PATCH v7 0/2] add command env erase

[Simon Goldschmidt]

Am 09.07.2019 um 21:48 schrieb Frank Wunderlich:
> Hi Simon
> 
> Am 9. Juli 2019 21:23:45 MESZ schrieb Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>:
>> I remember having answered to v5, then you sent v6 and without further
>> responses sent v7. I fail to read from the patches what actually
>> changed
>> between the versions. You have written a changelog in the cover letter,
>>
>> please do so for the different patches as well.
> 
> Only change between v6 and v7 is in 2/2 (mentioned in cover letter and 2/2 but there not as version history):
> 
> - fix whitespaces around errmsg

That's not the point. The point is it should be in the patch so I can 
jsut see it when finding the time to look at it.

I encourage you to rely on patman creating the cover letter and 
changelog for you (see 'tools/patman/README').

> 
> There are spaces instead of tabs i've seen after send v6. So i fixed that without waiting for responses.

That wouldn't have been a problem if the patches contained a changelog. 
And for patches without changes from one version to the next, include 
"-no changes" or something like that to let everyone know you did not 
forget the changelog (or just use patman :)

> 
> V6 has changed to be closer to saveenv like you suggested.

Yes, I've just sent by rb.

> 
>> Further, you have not integrated by Reviewed-by tag to 1/2 I sent for
>> v5...
> Sorry i missed that,1/2 afair has not changed since v5

No problem, I keep forgetting that too, just wanted to let you know.

Regards,
Simon

> 
>> I'll no go and manually diff v6 and v6, and then reply sigh...
>>
>> But even then, keep in mind I'm not the one mergin this!
> 
> Regards Frank
>