[U-Boot] [PATCH 4/5] toradex: configblock: fix apalis imx8 target

[Marcel Ziswiler]

Hi Igor

On Tue, 2019-07-09 at 10:27 +0000, Igor Opaniuk wrote:
> HI Marcel,
> 
> On Tue, Jul 9, 2019 at 12:43 PM Marcel Ziswiler <marcel at ziswiler.com>
> wrote:
> > From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > 
> > The Apalis iMX8 was missing the interactive part should a customer
> > have
> > bricked his module and want to re-create the configuration block.
> > Fix
> > this.
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > 
> > ---
> > 
> >  board/toradex/common/tdx-cfg-block.c | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> > 
> > diff --git a/board/toradex/common/tdx-cfg-block.c
> > b/board/toradex/common/tdx-cfg-block.c
> > index 90df5bb2ff..a81b0f637c 100644
> > --- a/board/toradex/common/tdx-cfg-block.c
> > +++ b/board/toradex/common/tdx-cfg-block.c
> > @@ -7,6 +7,7 @@
> >  #include "tdx-cfg-block.h"
> > 
> >  #if defined(CONFIG_TARGET_APALIS_IMX6) || \
> > +       defined(CONFIG_TARGET_APALIS_IMX8) || \
> >         defined(CONFIG_TARGET_COLIBRI_IMX6) || \
> >         defined(CONFIG_TARGET_COLIBRI_IMX8X)
> >  #include <asm/arch/sys_proto.h>
> > @@ -356,7 +357,19 @@ static int get_cfgblock_interactive(void)
> >                 tdx_hw_tag.prodid = COLIBRI_IMX7D;
> >         else if (!strcmp("imx7s", soc))
> >                 tdx_hw_tag.prodid = COLIBRI_IMX7S;
> > -       else if (is_cpu_type(MXC_CPU_IMX8QXP)) {
> > +       else if (is_cpu_type(MXC_CPU_IMX8QM)) {
> > +               if (it == 'y' || it == 'Y') {
> > +                       if (wb == 'y' || wb == 'Y')
> > +                               tdx_hw_tag.prodid =
> > APALIS_IMX8QM_WIFI_BT_IT;
> > +                       else
> > +                               tdx_hw_tag.prodid =
> > APALIS_IMX8QM_IT;
> > +               } else {
> > +                       if (wb == 'y' || wb == 'Y')
> > +                               tdx_hw_tag.prodid =
> > APALIS_IMX8QP_WIFI_BT;
> 
> Just curious why NXP guys decided to call this CPU type as
> MXC_CPU_IMX8QM,
> and why not to drop the last M, or even both QM (taking into account
> that marketing name is
> simple IMX8 for these SoC series [1]. and iMX8M and iMX8X
> respectively
> for M and X series),
> because it's not obvious for me that APALIS_IMX8QP has any relation
> to
> MXC_CPU_IMX8QM.

Good questions. Maybe some of the NXP folks dare answering?

Cheers

Marcel

> > +                       else
> > +                               tdx_hw_tag.prodid = APALIS_IMX8QP;
> > +               }
> > +       } else if (is_cpu_type(MXC_CPU_IMX8QXP)) {
> >                 if (it == 'y' || it == 'Y') {
> >                         if (wb == 'y' || wb == 'Y')
> >                                 tdx_hw_tag.prodid =
> > COLIBRI_IMX8QXP_WIFI_BT_IT;
> > --
> > 2.21.0
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
> 
> Reviewed-by: Igor Opaniuk <igor.opaniuk at toradex.com>
> 
> [1] https://en.wikipedia.org/wiki/I.MX#i.MX_8_series
> 
> -- 
> Best regards - Freundliche Grüsse - Meilleures salutations
> 
> Senior Development Engineer,
> Igor Opaniuk
> 
> Toradex AG
> Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 48
> 00 (main line)