[U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform supports the I2C driver model

Alex Marginean alexm.osslist at gmail.com
Fri Jul 12 11:46:58 UTC 2019


On 7/10/2019 4:16 PM, Chuanhua Han wrote:
> DM_I2C_COMPAT is a compatibility layer that allows using the non-DM
> I2C API when DM_I2C is used.When DM_I2C_COMPAT is not enabled for
> compilation, a compilation error will be generated. This patch
> solves the problem that the i2c-related api of the ls1028a platform
> does not support dm.

I wouldn't mention DM_I2C_COMPAT at all in the commit message, it's not
currently enabled and after this patch set it's not needed either.
You could just mention that the patch is updating ls1028a board init
code to support DM_I2C.

> 
> Signed-off-by: Chuanhua Han <chuanhua.han at nxp.com>
> ---
> depends on:
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=113364
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=110856
> 	- https://patchwork.ozlabs.org/project/uboot/list/?series=109677
> 
> Changes in v4:
> 	- No change.
> Changes in v3:
> 	- No change.
> Changes in v2:
> 	- No change.
> 
>   arch/arm/cpu/armv8/fsl-layerscape/Kconfig |    8 --------
>   board/freescale/ls1028a/ls1028a.c         |    8 ++++++++
>   include/configs/ls1028a_common.h          |    3 ---
>   include/configs/ls1028ardb.h              |    1 -
>   4 files changed, 8 insertions(+), 12 deletions(-)
> 

code changes look OK to me.

Reviewed-by: Alex Marginean <alexm.osslist at gmail.com>



More information about the U-Boot mailing list