[U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

[Sam Protsenko]

On Fri, Jul 12, 2019 at 3:50 PM Eugeniu Rosca <erosca at de.adit-jv.com> wrote:
>
> Fix warning V1037 reported by PVS-Studio Static Analyzer:
> Two or more case-branches perform the same actions. Check lines: 49, 53
>
> Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields")
> Signed-off-by: Eugeniu Rosca <erosca at de.adit-jv.com>
> Reviewed-by: Igor Opaniuk <igor.opaniuk at gmail.com>
> ---
> v2:
>  - Added 'Reviewed-by: Igor Opaniuk' from v1
>
> v1:
>  - https://patchwork.ozlabs.org/patch/1131301/
> ---

Reviewed-by: Sam Protsenko <semen.protsenko at linaro.org>

>  cmd/bcb.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/cmd/bcb.c b/cmd/bcb.c
> index 2bd5a744deb5..3b1c7434e287 100644
> --- a/cmd/bcb.c
> +++ b/cmd/bcb.c
> @@ -46,9 +46,6 @@ static int bcb_is_misused(int argc, char *const argv[])
>
>         switch (cmd) {
>         case BCB_CMD_LOAD:
> -               if (argc != 3)
> -                       goto err;
> -               break;
>         case BCB_CMD_FIELD_SET:
>                 if (argc != 3)
>                         goto err;
> --
> 2.22.0
>