[U-Boot] [PATCH 2/8] net: tsec: Fix offset of MDIO registers for DM_ETH

Vladimir Oltean olteanv at gmail.com
Sat Jul 13 09:44:14 UTC 2019


Hi Bin,

On Sat, 13 Jul 2019 at 07:55, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Vladimir,
>
> On Mon, Jun 24, 2019 at 1:50 AM Vladimir Oltean <olteanv at gmail.com> wrote:
> >
> > By convention, the eTSEC MDIO controller nodes are defined in DT at
> > 0x2d24000 and 0x2d50000, but actually U-boot does not touch the
>
> nits: U-Boot, not U-boot
>
> > interrupt portion of the register map (MDIO_IEVENTM, MDIO_IMASKM,
> > MDIO_EMAPM).
> >
> > That leaves only the MDIO bus registers (MDIO_MIIMCFG, MDIO_MIIMCOM,
> > MDIO_MIIMADD, MDIO_MIIMADD, MDIO_MIIMCON, MDIO_MIIMSTAT) which start at
> > the 0x520 offset.
> >
> > So shift the DT-defined register map by the offset of MDIO_MIIMCFG when
> > mapping the MDIO bus registers.
>
> Could you please create a TSEC MDIO DM driver based on this series
> that Alex has done?
>
> http://patchwork.ozlabs.org/project/uboot/list/?series=111504?
>

Yes I actually said in the cover letter that I want to do that, but it
has to get merged first :)

> >
> > Signed-off-by: Vladimir Oltean <olteanv at gmail.com>
> > ---
> >  drivers/net/tsec.c | 13 +++++++------
> >  include/tsec.h     |  4 +++-
> >  2 files changed, 10 insertions(+), 7 deletions(-)
> >
>
> Regards,
> Bin

Thanks,
-Vladimir


More information about the U-Boot mailing list