[U-Boot] [PATCH] cmd: mdio: prevent data abort when no mdio bus is found

Vladimir Oltean olteanv at gmail.com
Sat Jul 13 12:03:52 UTC 2019


On Fri, 12 Jul 2019 at 21:58, Simon Goldschmidt
<simon.k.r.goldschmidt at gmail.com> wrote:
>
> Calling 'mdio read ...' currently leads to a data abort when no mdio
> bus is found.
>
> To fix this, check if 'bus' is a valid pointer before accessing it.
>
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> ---

Tested-by: Vladimir Oltean <olteanv at gmail.com>
Reviewed-by: Vladimir Oltean <olteanv at gmail.com>

>
>  cmd/mdio.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/cmd/mdio.c b/cmd/mdio.c
> index 5e219f699d..e1f771d3ed 100644
> --- a/cmd/mdio.c
> +++ b/cmd/mdio.c
> @@ -263,6 +263,11 @@ static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>                 break;
>         }
>
> +       if (!bus) {
> +               puts("No MDIO bus found\n");
> +               return CMD_RET_FAILURE;
> +       }
> +
>         if (op[0] == 'l') {
>                 mdio_list_devices();
>
> --
> 2.20.1
>


More information about the U-Boot mailing list