[U-Boot] [PATCH 8/8] Add support for the NXP LS1021A-TSN board

[Vladimir Oltean]

Hi Bin,

On Sat, 13 Jul 2019 at 08:05, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Vladimir,
>
> On Mon, Jun 24, 2019 at 1:50 AM Vladimir Oltean <olteanv at gmail.com> wrote:
> >
> > From: Jianchao Wang <jianchao.wang at nxp.com>
> >
> > The LS1021A-TSN is a development board built by VVDN/Argonboards in
> > partnership with NXP.
> >
> > It features the LS1021A SoC and the first-generation SJA1105T Ethernet
> > switch for prototyping implementations of a subset of IEEE 802.1 TSN
> > standards.
> >
> > Supported boot media: microSD card (via SPL), QSPI flash.
> >
> > Rev. A of the board uses a Spansion S25FL512S_256K serial flash, which
> > is 64 MB in size and has an erase sector size of 256KB (therefore,
> > flashing the RCW would erase part of U-boot).
>
> nits: U-Boot
>

Why don't you add a rule to scripts/checkpatch.pl that warns on
improper spelling of U-Boot? It would save a lot of time on both ends.

> >
> > Rev. B and C of the board use a Spansion S25FL256S1 serial flash, which
> > is only 32 MB in size but has an erase sector size of 64KB (therefore
> > the RCW image can be flashed without erasing U-boot).
>
> ditto
>
> >
> > To avoid the problems above, the U-boot base address has been selected
>
> ditto
>

[snip]

> > +The LS1021A-TSN board comes along with a microSD card with OpenIL U-boot.
>
> nits: U-Boot
>
> > +That will be used to update the internal QSPI flash, as well as
> > +
> > +To compile and flash an SD card image::
> > +
> > +  make ls1021atsn_sdcard_defconfig && make -j 8 && sudo cp u-boot-with-spl-pbl.bin /srv/tftpboot/
> > +  => tftp 0x82000000 u-boot-with-spl-pbl.bin && mmc rescan && mmc erase 8 0x1100 && mmc write 0x82000000 8 0x1100
> > +
> > +For the QSPI flash, first obtain the Reset Configuration Word binary for
> > +bootimg from the QSPI flash from the rcw project
> > +(https://source.codeaurora.org/external/qoriq/qoriq-components/rcw)::
> > +
> > +  make -j 8 && sudo cp ls1021atsn/SSR_PNS_30/rcw_1200_qspiboot.bin.swapped /srv/tftpboot/
> > +
> > +The above RCW binary takes care of swapping the QSPI AMBA memory, so that the
> > +U-boot binary does not need to be swapped when flashing it.
>
> nits: U-Boot
>
> > +
> > +To compile and flash a U-boot image for QSPI::
>
> ditto
>
> > +
> > +  make ls1021atsn_qspi_defconfig && make -j 8 && sudo cp u-boot.bin /srv/tftpboot/
> > +
> > +Then optionally create a custom uboot-env.txt file (although the default
> > +environment already supports distro boot) and convert it to binary format::
> > +
> > +  mkenvimage -s 2M -o /srv/tftpboot/uboot-env.bin uboot-env.txt
> > +
> > +To program the QSPI flash with the images::
> > +
> > +  => tftp 0x82000000 rcw_1000_qspiboot.bin.swapped && sf probe && sf erase 0x0 +${filesize} && sf write 0x82000000 0x0 ${filesize}
> > +  => tftp 0x82000000 u-boot.bin && sf probe && sf erase 0x100000 +${filesize} && sf write 0x82000000 0x100000 ${filesize}
> > +  => tftp 0x82000000 uboot-env.bin && sf probe && sf erase 0x400000 +${filesize} && sf write 0x82000000 0x400000 ${filesize}
> > +
> > +The boards contain an AT24 I2C EEPROM that is supposed to hold the MAC
> > +addresses of the Ethernet interfaces, however the EEPROM comes blank out of
> > +the factory, and the MAC addresses are printed on a label on the bottom of
> > +the boards.
> > +
> > +To write the MAC addresses to the EEPROM, the following needs to be done once::
> > +
> > +  => mac id
> > +  => mac 0 00:1F:7B:xx:xx:xx
> > +  => mac 1 00:1F:7B:xx:xx:xx
> > +  => mac 2 00:1F:7B:xx:xx:xx
> > +  => mac save
> > +
> > +The switch ports do not have their own MAC address - they inherit it from the
> > +master enet2 port.
> > +
> > +Known issues and limitations
> > +============================
> > +
> > +- The 4 SJA1105 switch ports are not functional in U-boot for now.
>
> nits: U-Boot
>

[snip]

>
> Regards,
> Bin

Thanks,
-Vladimir