[U-Boot] [PATCH v4 1/8] x86: Add new slimbootloader CPU type

[Park, Aiden]

Hi Bin,

> -----Original Message-----
> From: Bin Meng [mailto:bmeng.cn at gmail.com]
> Sent: Monday, July 15, 2019 12:42 AM
> To: Park, Aiden <aiden.park at intel.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Simon Glass
> <sjg at chromium.org>
> Subject: Re: [PATCH v4 1/8] x86: Add new slimbootloader CPU type
> 
> On Mon, Jul 15, 2019 at 5:58 AM Park, Aiden <aiden.park at intel.com> wrote:
> >
> > This slimbootloader cpu type is to enable U-Boot as a payload which
> > runs on top of Slim Bootloader(https://github.com/slimbootloader).
> > The Slim Bootloader is designed with multi-stage architecture for the
> > execution from reset vector to OS booting, and supports qemu,
> > Apollolake, Whiskeylake and Coffeelake platforms consuming Intel FSP
> > (https://github.com/IntelFsp) for silicon initialization including CAR
> > and memory initialization.
> > The Slim Bootloader generates new HOB(Hand Off Block) which are serial
> > port info, memory map info, performance data info and so on, and
> > passes it to a Payload. U-Boot as a payload will use these HOB
> > information for basic initialization such as serial console.
> >
> > As an initial commit,
> > - Add CONFIG_SYS_SLIMBOOTLOADER to enable slimbootloader CPU type
> > - Add new arch/x86/cpu/slimbootloader directory with minimum codes
> > - Get hob_list pointer from Slim Bootloader
> >
> > Signed-off-by: Aiden Park <aiden.park at intel.com>
> > ---
> >
> > Changes in v4:
> >   * Use common arch/x86/cpu/start.S
> >   * Update U-boot or u-boot to U-Boot in commit message
> >
> > Changes in v3:
> >   * Add a brief description about Slim Bootloader
> >   * Enable USB_KEYBOARD, E1000 and RTL8169 by default
> >   * Fix comment from code review
> >
> >  arch/x86/Kconfig                              |  1 +
> >  arch/x86/cpu/Makefile                         |  1 +
> >  arch/x86/cpu/slimbootloader/Kconfig           | 26 +++++++++++++++++++
> >  arch/x86/cpu/slimbootloader/Makefile          |  5 ++++
> >  arch/x86/cpu/slimbootloader/car.S             | 14 ++++++++++
> >  arch/x86/cpu/slimbootloader/slimbootloader.c  | 21 +++++++++++++++
> >  arch/x86/cpu/start.S                          |  6 +++--
> >  .../asm/arch-slimbootloader/slimbootloader.h  | 11 ++++++++
> >  arch/x86/include/asm/global_data.h            |  2 +-
> >  arch/x86/lib/asm-offsets.c                    |  2 +-
> >  10 files changed, 85 insertions(+), 4 deletions(-)  create mode
> > 100644 arch/x86/cpu/slimbootloader/Kconfig
> >  create mode 100644 arch/x86/cpu/slimbootloader/Makefile
> >  create mode 100644 arch/x86/cpu/slimbootloader/car.S  create mode
> > 100644 arch/x86/cpu/slimbootloader/slimbootloader.c
> >  create mode 100644
> > arch/x86/include/asm/arch-slimbootloader/slimbootloader.h
> >
> 
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> 
> BTW: this series does not apply on top of u-boot-x86, can you please rebase?
Sure. Let me rebase this series. Thanks.
> 
> Regards,
> Bin

Best Regards,
Aiden