[U-Boot] [PATCH v2 1/2] rockchip: make_fit_atf.py: Eliminate pyelftools dependency

Chris Webb chris at arachsys.com
Tue Jul 16 11:46:52 UTC 2019


Hi Andy and Kever

Andy Yan <andy.yan at rock-chips.com> writes:

> One small coding style issue:
> 
> offset = e_phoff + e_phentsize * index

Thanks, will fix this.

Kever Yang <kever.yang at rock-chips.com> writes:

> Please fix the coding style comment by Andy, for other codes:
> 
> Reviewed-by: Kever Yang <Kever.yang at rock-chips.com>

Newbie contributor so can I check: is it right to add this Reviewed-by:
line to the end of the patch commit message after my Signed-off-by: when I
resend the patches as v3 with the style correction?

Many thanks,
Chris.


More information about the U-Boot mailing list