[U-Boot] [PATCH v3 22/57] ram: rk3399: Add lpddr4 rank mask for wdql training

Kever Yang kever.yang at rock-chips.com
Tue Jul 16 13:11:49 UTC 2019


On 2019/7/16 下午7:57, Jagan Teki wrote:
> Add rank_mask based on the rank number for lpddr4.
>
> This would keep the wdql data training loop based on the
> desired rank mask value instead of looping for all values.
>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> Signed-off-by: YouMin Chen <cym at rock-chips.com>

Reviewed-by: Kever Yang <Kever.yang at rock-chips.com>

Thanks,
  - Kever
> ---
>   drivers/ram/rockchip/sdram_rk3399.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index 8ecc3a1b74..711477188e 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -925,7 +925,10 @@ static int data_training_wdql(const struct chan_info *chan, u32 channel,
>   	/* clear interrupt,PI_175 PI_INT_ACK:WR:0:17 */
>   	writel(0x00003f7c, (&denali_pi[175]));
>   
> -	rank_mask = (rank == 1) ? 0x1 : 0x3;
> +	if (params->base.dramtype == LPDDR4)
> +		rank_mask = (rank == 1) ? 0x5 : 0xf;
> +	else
> +		rank_mask = (rank == 1) ? 0x1 : 0x3;
>   
>   	for (i = 0; i < 4; i++) {
>   		if (!(rank_mask & (1 << i)))




More information about the U-Boot mailing list