[U-Boot] [EXT] Re: [Patch V3] drivers: mtd :spi: Enable 4B opcodes for SPANSION s25fl512s

[Ashish Kumar]

> -----Original Message-----
> From: Jagan Teki <jagan at amarulasolutions.com>
> Sent: Thursday, July 18, 2019 3:59 PM
> To: Ashish Kumar <ashish.kumar at nxp.com>; Vignesh R <vigneshr at ti.com>
> Cc: U-Boot-Denx <u-boot at lists.denx.de>
> Subject: [EXT] Re: [Patch V3] drivers: mtd :spi: Enable 4B opcodes for
> SPANSION s25fl512s
> 
> Caution: EXT Email
> 
> + Vignesh
> 
> On Wed, Jul 17, 2019 at 11:46 AM Ashish Kumar <Ashish.Kumar at nxp.com>
> wrote:
> >
> > s25fs512s and s25fl512s which has same JEDEC ID but only varies in
> > operating volatge so s25fs512s shares same command set as mentioned
> > below:
> > – Serial Command subset and footprint compatible with S25FL-A,
> > S25FL-K, S25FL-P, and S25FL-S SPI families – Multi I/O Command subset
> > and footprint compatible with S25FL-P, and S25FL-S SPI families
> >
> > Signed-off-by: Ashish Kumar <Ashish.Kumar at nxp.com>
> > ---
> > v3:
> > 1. Add version info, rebase to top.
> > 2. Re-word commit message.
> > v2:
> > 1. Adding more description in commit msg.
> > 2. consolidating "" and  "" in single patch.
> >
> >  drivers/mtd/spi/spi-nor-ids.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi/spi-nor-ids.c
> > b/drivers/mtd/spi/spi-nor-ids.c index 3217fc6..a992966 100644
> > --- a/drivers/mtd/spi/spi-nor-ids.c
> > +++ b/drivers/mtd/spi/spi-nor-ids.c
> > @@ -181,7 +181,7 @@ const struct flash_info spi_nor_ids[] = {
> >         { INFO("s25sl064p",  0x010216, 0x4d00,  64 * 1024, 128,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >         { INFO("s25fl256s0", 0x010219, 0x4d00, 256 * 1024, 128, USE_CLSR) },
> >         { INFO("s25fl256s1", 0x010219, 0x4d01,  64 * 1024, 512,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> > -       { INFO6("s25fl512s",  0x010220, 0x4d0081, 256 * 1024, 256,
> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
> > +       { INFO6("s25fl512s",  0x010220, 0x4d0081, 256 * 1024, 256,
> > + SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR |
> > + SPI_NOR_4B_OPCODES) },
> 
> I didn't find any diff b/w this with respect to v1 patch, seems like Vignesh
> commented some issue? any update on that.

Hi Jagan, Vignesh,

I had updated commit message.

Wrt Vignesh's comment:
To me it seems not valid. This Flash can be used in extended 3-byte addressing mode as well as 4-byte addressing mode.
Adding SPI_NOR_4B_OPCODE, will make use of 4-byte addressing mode with CONFIG_SPI_FLASH_BAR being __not__ set.
By adding SPI_NOR_4B_OPCODES code flow will via spi_nor_set_4byte_opcodes() in place of set_4byte().

There is patch to unset CONFIG_SPI_FLASH_BAR, for boards that are using 4-byte addressing mode with this flash
http://patchwork.ozlabs.org/patch/1108287/


Regards
Ashish