[U-Boot] [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a and mt35xu02g flash ID

[Ashish Kumar]

> -----Original Message-----
> From: Jagan Teki <jagan at amarulasolutions.com>
> Sent: Thursday, July 18, 2019 5:00 PM
> To: Ashish Kumar <ashish.kumar at nxp.com>
> Cc: U-Boot-Denx <u-boot at lists.denx.de>; Kuldeep Singh
> <kuldeep.singh at nxp.com>
> Subject: Re: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron mt35xu512a
> and mt35xu02g flash ID
> 
> Caution: EXT Email
> 
> On Thu, Jul 18, 2019 at 4:56 PM Ashish Kumar <ashish.kumar at nxp.com>
> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Jagan Teki <jagan at amarulasolutions.com>
> > > Sent: Thursday, July 18, 2019 4:48 PM
> > > To: Ashish Kumar <ashish.kumar at nxp.com>
> > > Cc: U-Boot-Denx <u-boot at lists.denx.de>; Kuldeep Singh
> > > <kuldeep.singh at nxp.com>
> > > Subject: Re: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron
> > > mt35xu512a and mt35xu02g flash ID
> > >
> > > Caution: EXT Email
> > >
> > > On Thu, Jul 18, 2019 at 4:43 PM Ashish Kumar <ashish.kumar at nxp.com>
> > > wrote:
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Jagan Teki <jagan at amarulasolutions.com>
> > > > > Sent: Thursday, July 18, 2019 4:32 PM
> > > > > To: Ashish Kumar <ashish.kumar at nxp.com>
> > > > > Cc: U-Boot-Denx <u-boot at lists.denx.de>; Kuldeep Singh
> > > > > <kuldeep.singh at nxp.com>
> > > > > Subject: [EXT] Re: [Patch v4] drivers: mtd: spi: Add micron
> > > > > mt35xu512a and mt35xu02g flash ID
> > > > >
> > > > > Caution: EXT Email
> > > > >
> > > > > On Thu, Jul 18, 2019 at 4:20 PM Ashish Kumar
> > > > > <Ashish.Kumar at nxp.com>
> > > > > wrote:
> > > > > >
> > > > > > mt35xu512a and mt35xu02g suports Single I/O and OCTAL I/O also
> > > > > > enable use of SPI_NOR_4B_OPCODES.
> > > > > >
> > > > > > These flashes are tested on LX2160ARDB and LS1028ARDB
> > > > > > respectively
> > > > > >
> > > > > > Signed-off-by: Kuldeep Singh <kuldeep.singh at nxp.com>
> > > > > > Signed-off-by: Ashish Kumar <Ashish.Kumar at nxp.com>
> > > > > > ---
> > > > > > v4:
> > > > > > Correct flash name to mt35xu512a in place of mt35xu512g
> > > > > > v3:
> > > > > > 1. Add version info, rebase to top
> > > > > > v2:
> > > > > > 1. Adding more description in commit msg.
> > > > > > 2. consolidating
> > > > > "http://patch
> > > > >
> > >
> work.ozlabs.org%2Fpatch%2F1097867%2F&data=02%7C01%7CAshish.Ku
> > > > >
> > >
> mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b
> > > > >
> > >
> 4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&sdata=FqeZ
> > > > >
> haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&reserved=0"
> > > > > >  and
> > > > > "http://patch
> > > > >
> > >
> work.ozlabs.org%2Fpatch%2F1097867%2F&data=02%7C01%7CAshish.Ku
> > > > >
> > >
> mar%40nxp.com%7C1a070b5bf43e41bffb6308d70b6f5665%7C686ea1d3bc2b
> > > > >
> > >
> 4c6fa92cd99c5c301635%7C0%7C0%7C636990445127446746&sdata=FqeZ
> > > > >
> haZNxwQtX2tW1HHXhmEuV1tVPjkxuKbDmr405Ao%3D&reserved=0"
> > > in single
> > > > > patch.
> > > > > >
> > > > > >  drivers/mtd/spi/spi-nor-ids.c | 2 ++
> > > > > >  1 file changed, 2 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/mtd/spi/spi-nor-ids.c
> > > > > > b/drivers/mtd/spi/spi-nor-ids.c index d99c4c5..32a540d 100644
> > > > > > --- a/drivers/mtd/spi/spi-nor-ids.c
> > > > > > +++ b/drivers/mtd/spi/spi-nor-ids.c
> > > > > > @@ -170,6 +170,8 @@ const struct flash_info spi_nor_ids[] = {
> > > > > >         { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K |
> > > USE_FSR
> > > > > | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> > > > > >         { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K |
> > > USE_FSR
> > > > > | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> > > > > >         { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K |
> > > > > USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> > > > > > +       { INFO6("mt35xu512a", 0x2c5b1a, 0x104100,  128 * 1024,
> > > > > > + 512, USE_FSR | SPI_NOR_4B_OPCODES) },
> > > > >
> > > > > Again is this same as mt35xu512aba? if yes we can have it on
> > > > > INFO itself
> > > is it?
> > > >
> > > > Update to INFO from INFO6
> > >
> > > but mt35xu512a is same as mt35xu512aba? if yes I can apply your v5
> > > by updating this.
> >
> > Yes, but I thought we are not mentioning device generation and die
> revision (mt25xu512aBA) option in id-table.
> > Device Generation
> > B = 2nd generation
> > Die Revision
> > A = Rev. A
> 
> Since Linux follow this, I wonder something has been discussed for this.
Ok, I do not see any harm in keeping mt35xu512aba in place mt35xu512a.

Regards
Ashish