[U-Boot] [PATCH v2 05/12] armV7R: K3: am654: Allow using SPL BSS pre-relocation

[Simon Goldschmidt]

On Fri, Jul 19, 2019 at 2:29 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, Jun 04, 2019 at 05:55:48PM -0500, Andreas Dannenberg wrote:
>
> > In order to be able to use more advanced driver functionality which often
> > relies on having BSS initialized during early boot prior to relocation
> > several things need to be in place:
> >
> > 1) Memory needs to be available for BSS to use. For this, we locate BSS
> >    at the top of the MCU SRAM area, with the stack starting right below
> >    it,
> > 2) We need to move the initialization of BSS prior to entering
> >    board_init_f(). We will do this with a separate commit by turning on
> >    the respective CONFIG option.
> >
> > In this commit we also clean up the assignment of the initial SP address
> > as part of the refactoring, taking into account the pre-decrement post-
> > increment nature in which the SP is used on ARM.
> >
> > Signed-off-by: Andreas Dannenberg <dannenberg at ti.com>
>
> Applied to u-boot/master, thanks!

Wait, why has this been merged? Unfortunately, I haven't followed this series,
but in a discussion about a similar patch I sent [1], using BSS from
board_init_f
was turned down. And Simon Glass rather convinced me that this is the current
API U-Boot has (and is documented in README).

So either we must change this API and its documentation (and I would expect the
author of this patch to combine the README change with the code change), or this
patch would have to be rejected.

Again, I'm sorry I only see this now. In thought to remember a
discussion in this
thread, but I clearly remember that wrong...

[1] https://patchwork.ozlabs.org/patch/1057237/

Regards,
Simon

>
> --
> Tom