[U-Boot] [RFC 1/1] efi_loader: usage of cleanup_before_linux()

Peter Robinson pbrobinson at gmail.com
Fri Jul 19 06:26:19 UTC 2019


On Thu, Jul 18, 2019 at 9:47 PM Leif Lindholm <leif.lindholm at linaro.org> wrote:
>
> On Thu, Jul 18, 2019 at 08:53:01PM +0200, Alexander Graf wrote:
> >
> > On 18.07.19 19:46, Heinrich Schuchardt wrote:
> > > Always call cleanup_before_linux() on ARM 32bit during ExitBootServices().
> > >
> > > This fixes a problem problem for booting BSD on ARM 32bit.
> > >
> > > Reported-by: Jonathan Gray <jsg at jsg.id.au>
> > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> >
> > NAK. Instead this should never call cleanup_before_linux() and we declare
> > ourselves incompatible to old grub versions. That way we don't lure others
> > into believing you could boot with caches disabled in a UEFI world.
>
> Agreed.
>
> This is my fault by the way, for merging a loader in GRUB that was
> designed to be used without the linux EFI stub (way, waaaay back).
> Feel free to shout.
>
> As of GRUB 2.04 release (and cherry-picked into debian Buster before
> that), the 32-bit and 64-bit UEFI ports use the same loader.

Do you have a reference to this patch set handy?

Peter


More information about the U-Boot mailing list